xaymar/obs-ffmpeg-encoder
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 14 Wiki Activity

locale: Text labels for some options #13

Merged
UserNaem merged 4 commits from patch-1 into master 2019-11-10 08:09:41 +01:00
Conversation 12 Commits 4 Files Changed 1
+14 -1
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 79377a1c3b - Show all commits
data/locale/en-US.ini
+14 -1
View File
@@ -46,6 +46,8 @@ KeyFrames="Key Frames"
KeyFrames.IntervalType="Interval Type"
Xaymar commented 2019-11-05 14:15:03 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

Description text is incorrect, higher values are not correlated with more efficient compression. Higher values may cause less efficient compression due to no proper reference frame being left. Information about video editors should also not be added here as it is specific to certain video editors and not a general observation that applies to all of them.

Description text is incorrect, higher values are not correlated with more efficient compression. Higher values may cause less efficient compression due to no proper reference frame being left. Information about video editors should also not be added here as it is specific to certain video editors and not a general observation that applies to all of them.
Xaymar commented 2019-11-05 14:23:11 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

For example, Resolve works perfectly fine with keyframes every 15 seconds, but Adobe Premiere Pro struggles with it.

For example, Resolve works perfectly fine with keyframes every 15 seconds, but Adobe Premiere Pro struggles with it.
Xaymar commented 2019-11-07 09:37:30 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

Might be best to remove the default value here, as it may change and can be better shown by OBS's UI code instead of being put into the tooltip.

Might be best to remove the default value here, as it may change and can be better shown by OBS's UI code instead of being put into the tooltip.
UserNaem commented 2019-11-10 00:50:36 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

OBS' UI doesn't offer an immediately apparent way to unset any changed settings to default, so I thought putting a note somewhere "if you broke it, here's how to unbreak" would help, but if you intend on putting it in later, this won't be useful.

OBS' UI doesn't offer an immediately apparent way to unset any changed settings to default, so I thought putting a note somewhere "if you broke it, here's how to unbreak" would help, but if you intend on putting it in later, this won't be useful.
Xaymar commented 2019-11-10 08:30:27 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

Yes, but there's a need for a UI rework in OBS anyway. Including default values shouldn't be an issue once the decisions have been made there.

Yes, but there's a need for a UI rework in OBS anyway. Including default values shouldn't be an issue once the decisions have been made there.
KeyFrames.IntervalType.Frames="Frames"
KeyFrames.IntervalType.Seconds="Seconds"
KeyFrames.IntervalType.Description="Keyframe interval type"
KeyFrames.Interval.Description="Distance between key frames, in frames or seconds.\nHigher values allow for more efficient compression,\nat the expense of slower seeking; some video editors may\nsuffer a performance decrease. Default is 2 seconds."
KeyFrames.Interval="Interval"
# Codec: H264
@@ -55,18 +57,23 @@ Codec.H264.Profile.baseline="Baseline"
Codec.H264.Profile.main="Main"
Xaymar commented 2019-11-05 14:15:50 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

Recommendations for profiles should not be included. Information about "modern devices" is also not necessary here.

Recommendations for profiles should not be included. Information about "modern devices" is also not necessary here.
Xaymar commented 2019-11-05 14:17:10 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

The last statement is unconfirmed, and thus should be removed. There are encoders that willingly pick higher levels in order to give themselves more room or enable features that can better compress things.

The last statement is unconfirmed, and thus should be removed. There are encoders that willingly pick higher levels in order to give themselves more room or enable features that can better compress things.
Xaymar commented 2019-11-05 14:17:19 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

Comments should not be added.

Comments should not be added.
Xaymar commented 2019-11-05 14:17:27 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

Comments should not be added.

Comments should not be added.
Xaymar commented 2019-11-05 14:17:42 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

See Codec.H264.Level.Description.

See Codec.H264.Level.Description.
Codec.H264.Profile.high="High"
Codec.H264.Profile.high444p="High 4:4:4 Predictive"
Codec.H264.Profile.Description="H.264 profile determines which features of the codec can be used.\nSince all modern devices can decode High perfectly, you should avoid using Main and Baseline,\nunless you need playback on very old devices and software decoding performance is not satisfactory.\nHigh 4:4:4 Predictive is required for YUV 4:4:4 color space."
Codec.H264.Level="Level"
Codec.H264.Level.Description="Level determines the upper limits of resolution, frame rate and bitrate for the video. Automatic will use the lowest level possible for your settings."
# Codec: HEVC
Codec.HEVC="HEVC"
Codec.HEVC.Profile="Profile"
#Codec.HEVC.Profile.Description="Placeholder text"
Codec.HEVC.Profile.main="Main"
Codec.HEVC.Profile.main10="Main 10-bit"
Codec.HEVC.Profile.rext="Range Extended"
Codec.HEVC.Tier="Tier"
#Codec.HEVC.Tier.Description="Placeholder text"
Codec.HEVC.Tier.main="Main"
Codec.HEVC.Tier.high="High"
Codec.HEVC.Level="Level"
Codec.HEVC.Level.Description="Level determines the upper limits of resolution, frame rate and bitrate for the video. Automatic will use the lowest level possible for your settings."
# Codec: Apple ProRes
Codec.ProRes.Profile="Profile"
@@ -79,6 +86,7 @@ Codec.ProRes.Profile.AP4X="4444 Extra Quality/XQ (AP4X)"
Xaymar commented 2019-11-05 14:18:35 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

"for NVENC" can be excluded here as this will only show up on NVENC.

"for NVENC" can be excluded here as this will only show up on NVENC.
# NVENC
NVENC.Preset="Preset"
NVENC.Preset.Description="Presets are NVIDIA's preconfigured default settings for NVENC."
NVENC.Preset.Default="Default"
NVENC.Preset.Slow="Slow"
NVENC.Preset.Medium="Medium"
4
 @@ -93,6 +101,7 @@ NVENC.Preset.Lossless="Lossless"
NVENC.Preset.LosslessHighPerformance="Lossless High Performance"
Xaymar commented 2019-11-05 14:20:08 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

Please split the description here up into NVENC.RateControl.Mode.XXX.Description, as having one huge description breaks the layout on smaller monitors or high DPI monitors.

Please split the description here up into NVENC.RateControl.Mode.XXX.Description, as having one huge description breaks the layout on smaller monitors or high DPI monitors.
NVENC.RateControl="Rate Control Options"
NVENC.RateControl.Mode="Mode"
NVENC.RateControl.Mode.Description="Constant Quantization Parameter: A flat compression ratio with no regard for bit rates. This yields the highest quality-per-bitrate.\nVariable Bitrate: Where appropriate, sacrifices quality to stay below the upper bitrate limit, or saves bitrate where possible.\nHigh Quality Variable Bitrate: Variable Bitrate with two-pass encoding enabled by default.\nConstant Bitrate: Similar to Variable Bitrate, but performs bit stuffing to avoid falling below the target bitrate.\nHigh Quality Constant Bitrate: Constant Bitrate with two-pass encoding enabled by default.\nLow Delay High Quality Constant Bitrate: Optimized for lowest encoding latency, mainly by disabling B-frames and using slice multithreading."
NVENC.RateControl.Mode.CQP="Constant Quantization Parameter"
NVENC.RateControl.Mode.VBR="Variable Bitrate"
NVENC.RateControl.Mode.VBR_HQ="High Quality Variable Bitrate"
@@ -109,7 +118,9 @@ NVENC.RateControl.TwoPass="Enable Two Pass"
NVENC.RateControl.TwoPass.Description="Enable a secondary pass for encoding, which can help with quality and bitrate stability.\nImproves quality slightly at the cost of some GPU time.\nNvidia Turing hardware might actually see a quality degrade from this."
Xaymar commented 2019-11-05 14:20:19 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

No comments.

No comments.
NVENC.RateControl.Bitrate="Bitrate Limits"
NVENC.RateControl.Bitrate.Target="Target Bitrate"
NVENC.RateControl.Bitrate.Target.Description="Target bitrate, in kilobits per second."
Xaymar commented 2019-11-07 09:51:26 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

, in kilobits per second is part of the general UI, there should be a kbit/s suffix in the field.

`, in kilobits per second` is part of the general UI, there should be a kbit/s suffix in the field.
UserNaem commented 2019-11-10 00:46:30 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

This leaves me with a tooltip that says "Target bitrate." I'll remove that, too.

This leaves me with a tooltip that says "Target bitrate." I'll remove that, too.
NVENC.RateControl.Bitrate.Maximum="Maximum Bitrate"
#NVENC.RateControl.Bitrate.Maximum.Description="Plaseholder text"
NVENC.RateControl.Quality="Enable Quality Limits"
NVENC.RateControl.Quality.Minimum="Minimum Quality"
NVENC.RateControl.Quality.Minimum.Description="Minimum quality to achieve, with values closer to 0 being better quality."
@@ -139,10 +150,12 @@ NVENC.AQ.Temporal="Enable Temporal Adaptive Quantization"
NVENC.AQ.Temporal.Description="Enable temporal adaptive quantization."
Xaymar commented 2019-11-05 14:21:22 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

Turing NVENC restriction should be moved to the end of the tooltip.

Turing NVENC restriction should be moved to the end of the tooltip.
Xaymar commented 2019-11-05 14:21:32 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

Yes, that is possible.

Yes, that is possible.
Xaymar commented 2019-11-05 14:21:43 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

See previous no comments.

See previous no comments.
UserNaem commented 2019-11-06 02:38:23 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

How to do this, exactly? I tried "" and it still shows the same tooltip, I tried " " and it shows a tooltip with a whitespace character.

How to do this, exactly? I tried `""` and it still shows the same tooltip, I tried `" "` and it shows a tooltip with a whitespace character.
Xaymar commented 2019-11-07 09:32:32 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

I just have to remove the code in the ui handler for it.

I just have to remove the code in the ui handler for it.
NVENC.Other="Other Options"
NVENC.Other.BFrames="Maximum B-Frames"
NVENC.Other.BFrames.Description="Maximum number of B-Frames to insert into the encoded bitstream.\nActual number of B-Frames may be lower depending on content and lookahead settings."
NVENC.Other.BFrames.Description="Maximum number of B-Frames to insert into the encoded bitstream.\nOnly Turing NVENC supports B-Frames for HEVC.\nActual number of B-Frames may be lower depending on content and lookahead settings."
NVENC.Other.BFrameReferenceMode="B-Frame Reference Mode"
NVENC.Other.BFrameReferenceMode.Each="Each B-Frame will be used for references"
NVENC.Other.BFrameReferenceMode.Middle="Only (# of B-Frames)/2 will be used for references"
#This is already explained in the drop-down list, but there is also a placeholder tooltip text. Is there a way to disable the tooltip here?
#NVENC.Other.BFrameReferenceMode.Description="Plaseholder text"
NVENC.Other.ZeroLatency="Enable Zero Latency"
NVENC.Other.ZeroLatency.Description="Enable zero latency operation, which ensures that there is no reordering delay."
NVENC.Other.WeightedPrediction="Enable Weighted Prediction"