locale: Text labels for some options #13
Reference in New Issue
Block a user
Delete Branch "patch-1"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I don't know enough about HEVC tiers and "maximum bitrate" in VBR, so I left some "placeholder text" commented out. Also, not sure about line 158.
Description
Added some explanations where I could, in hopes of them being useful. Also added commented-out placeholder texts for missing labels.
Motivation and Context
Issue #11
How Has This Been Tested?
Works on my machine
Types of changes
Documentation (a change to documentation pages)
Checklist:
Some changes required. Let's not make the tooltip overly complex, as it may have to be translated into other languages.
@@ -46,6 +46,8 @@ KeyFrames="Key Frames"KeyFrames.IntervalType="Interval Type"Description text is incorrect, higher values are not correlated with more efficient compression. Higher values may cause less efficient compression due to no proper reference frame being left. Information about video editors should also not be added here as it is specific to certain video editors and not a general observation that applies to all of them.
@@ -55,7 +57,9 @@ Codec.H264.Profile.baseline="Baseline"Codec.H264.Profile.main="Main"Recommendations for profiles should not be included. Information about "modern devices" is also not necessary here.
The last statement is unconfirmed, and thus should be removed. There are encoders that willingly pick higher levels in order to give themselves more room or enable features that can better compress things.
Comments should not be added.
Comments should not be added.
See Codec.H264.Level.Description.
@@ -79,6 +84,7 @@ Codec.ProRes.Profile.AP4X="4444 Extra Quality/XQ (AP4X)"# NVENCNVENC.Preset="Preset""for NVENC" can be excluded here as this will only show up on NVENC.
@@ -93,12 +99,19 @@ NVENC.Preset.Lossless="Lossless"NVENC.Preset.LosslessHighPerformance="Lossless High Performance"NVENC.RateControl="Rate Control Options"NVENC.RateControl.Mode="Mode"Please split the description here up into NVENC.RateControl.Mode.XXX.Description, as having one huge description breaks the layout on smaller monitors or high DPI monitors.
@@ -102,3 +114,4 @@NVENC.RateControl.Mode.CBR_LD_HQ.Description="Constant Bitrate optimized for lowest encoding latency."NVENC.RateControl.LookAhead="Look Ahead"NVENC.RateControl.LookAhead.Description="Look ahead this many frames while encoding to better distribute bitrate.\nImproves quality slightly at the cost of some GPU time.\nSet to 0 to disable."NVENC.RateControl.AdaptiveI="Enable adaptive I-Frame insertion"No comments.
Turing NVENC restriction should be moved to the end of the tooltip.
Yes, that is possible.
See previous no comments.
@@ -46,6 +46,8 @@ KeyFrames="Key Frames"KeyFrames.IntervalType="Interval Type"For example, Resolve works perfectly fine with keyframes every 15 seconds, but Adobe Premiere Pro struggles with it.
How to do this, exactly? I tried
""and it still shows the same tooltip, I tried" "and it shows a tooltip with a whitespace character.Should be good now, I hope.
I just have to remove the code in the ui handler for it.
Almost perfect, just a few minor issues. On a side note, could you group the descriptions for the rate control modes with the names for the rate control modes? They're currently out of order.
@@ -46,6 +46,8 @@ KeyFrames="Key Frames"KeyFrames.IntervalType="Interval Type"Might be best to remove the default value here, as it may change and can be better shown by OBS's UI code instead of being put into the tooltip.
@@ -93,12 +99,19 @@ NVENC.Preset.Lossless="Lossless"NVENC.Preset.LosslessHighPerformance="Lossless High Performance"\nThis yields the highest quality-per-bitrate.since this depends on the users settings, don't include it.This should actually describe what CBR does, not how it works.
For example:
, mainly by disabling B-frames and using slice multithreadingdoes not apply to NVENC unless you know how all NVENC chips work internally., in kilobits per secondis part of the general UI, there should be a kbit/s suffix in the field.@@ -93,12 +99,19 @@ NVENC.Preset.Lossless="Lossless"NVENC.Preset.LosslessHighPerformance="Lossless High Performance"I can't think of a good way to explain this myself, so I'll go with your description.
This leaves me with a tooltip that says "Target bitrate." I'll remove that, too.
@@ -46,6 +46,8 @@ KeyFrames="Key Frames"KeyFrames.IntervalType="Interval Type"OBS' UI doesn't offer an immediately apparent way to unset any changed settings to default, so I thought putting a note somewhere "if you broke it, here's how to unbreak" would help, but if you intend on putting it in later, this won't be useful.
Updated again.
@@ -46,6 +46,8 @@ KeyFrames="Key Frames"KeyFrames.IntervalType="Interval Type"Yes, but there's a need for a UI rework in OBS anyway. Including default values shouldn't be an issue once the decisions have been made there.