xaymar/obs-ffmpeg-encoder
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 14 Wiki Activity

locale: Text labels for some options #13

Merged
UserNaem merged 4 commits from patch-1 into master 2019-11-10 08:09:41 +01:00
Conversation 12 Commits 4 Files Changed 1
+14 -1
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
data/locale/en-US.ini
+14 -1
View File
@@ -46,6 +46,8 @@ KeyFrames="Key Frames"
KeyFrames.IntervalType="Interval Type"
Xaymar commented 2019-11-05 14:15:03 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

Description text is incorrect, higher values are not correlated with more efficient compression. Higher values may cause less efficient compression due to no proper reference frame being left. Information about video editors should also not be added here as it is specific to certain video editors and not a general observation that applies to all of them.

Description text is incorrect, higher values are not correlated with more efficient compression. Higher values may cause less efficient compression due to no proper reference frame being left. Information about video editors should also not be added here as it is specific to certain video editors and not a general observation that applies to all of them.
Xaymar commented 2019-11-05 14:23:11 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

For example, Resolve works perfectly fine with keyframes every 15 seconds, but Adobe Premiere Pro struggles with it.

For example, Resolve works perfectly fine with keyframes every 15 seconds, but Adobe Premiere Pro struggles with it.
Xaymar commented 2019-11-07 09:37:30 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

Might be best to remove the default value here, as it may change and can be better shown by OBS's UI code instead of being put into the tooltip.

Might be best to remove the default value here, as it may change and can be better shown by OBS's UI code instead of being put into the tooltip.
UserNaem commented 2019-11-10 00:50:36 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

OBS' UI doesn't offer an immediately apparent way to unset any changed settings to default, so I thought putting a note somewhere "if you broke it, here's how to unbreak" would help, but if you intend on putting it in later, this won't be useful.

OBS' UI doesn't offer an immediately apparent way to unset any changed settings to default, so I thought putting a note somewhere "if you broke it, here's how to unbreak" would help, but if you intend on putting it in later, this won't be useful.
Xaymar commented 2019-11-10 08:30:27 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

Yes, but there's a need for a UI rework in OBS anyway. Including default values shouldn't be an issue once the decisions have been made there.

Yes, but there's a need for a UI rework in OBS anyway. Including default values shouldn't be an issue once the decisions have been made there.
KeyFrames.IntervalType.Frames="Frames"
KeyFrames.IntervalType.Seconds="Seconds"
KeyFrames.IntervalType.Description="Keyframe interval type"
KeyFrames.Interval.Description="Distance between key frames, in frames or seconds."
KeyFrames.Interval="Interval"
# Codec: H264
@@ -55,7 +57,9 @@ Codec.H264.Profile.baseline="Baseline"
Codec.H264.Profile.main="Main"
Xaymar commented 2019-11-05 14:15:50 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

Recommendations for profiles should not be included. Information about "modern devices" is also not necessary here.

Recommendations for profiles should not be included. Information about "modern devices" is also not necessary here.
Xaymar commented 2019-11-05 14:17:10 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

The last statement is unconfirmed, and thus should be removed. There are encoders that willingly pick higher levels in order to give themselves more room or enable features that can better compress things.

The last statement is unconfirmed, and thus should be removed. There are encoders that willingly pick higher levels in order to give themselves more room or enable features that can better compress things.
Xaymar commented 2019-11-05 14:17:19 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

Comments should not be added.

Comments should not be added.
Xaymar commented 2019-11-05 14:17:27 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

Comments should not be added.

Comments should not be added.
Xaymar commented 2019-11-05 14:17:42 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

See Codec.H264.Level.Description.

See Codec.H264.Level.Description.
Codec.H264.Profile.high="High"
Codec.H264.Profile.high444p="High 4:4:4 Predictive"
Codec.H264.Profile.Description="H.264 profile determines which features of the codec can be used.\nHigh 4:4:4 Predictive is required for YUV 4:4:4 color space."
Codec.H264.Level="Level"
Codec.H264.Level.Description="Level determines the upper limits of resolution, frame rate and bitrate for the video."
# Codec: HEVC
Codec.HEVC="HEVC"
@@ -67,6 +71,7 @@ Codec.HEVC.Tier="Tier"
Codec.HEVC.Tier.main="Main"
Codec.HEVC.Tier.high="High"
Codec.HEVC.Level="Level"
Codec.HEVC.Level.Description="Level determines the upper limits of resolution, frame rate and bitrate for the video."
# Codec: Apple ProRes
Codec.ProRes.Profile="Profile"
@@ -79,6 +84,7 @@ Codec.ProRes.Profile.AP4X="4444 Extra Quality/XQ (AP4X)"
# NVENC
NVENC.Preset="Preset"
Xaymar commented 2019-11-05 14:18:35 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

"for NVENC" can be excluded here as this will only show up on NVENC.

"for NVENC" can be excluded here as this will only show up on NVENC.
NVENC.Preset.Description="Presets are NVIDIA's preconfigured default settings."
NVENC.Preset.Default="Default"
NVENC.Preset.Slow="Slow"
NVENC.Preset.Medium="Medium"
@@ -93,12 +99,19 @@ NVENC.Preset.Lossless="Lossless"
NVENC.Preset.LosslessHighPerformance="Lossless High Performance"
Xaymar commented 2019-11-07 09:41:48 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

\nThis yields the highest quality-per-bitrate. since this depends on the users settings, don't include it.

`\nThis yields the highest quality-per-bitrate.` since this depends on the users settings, don't include it.
Xaymar commented 2019-11-07 09:44:01 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

This should actually describe what CBR does, not how it works.

For example:

Compresses footage so that it matches the target bitrate over the duration of one second. This comes at a cost in quality during high motion scenes or scenes with flickering brightness like often seen in RPGs.

This should actually describe what CBR does, not how it works. For example: > Compresses footage so that it matches the target bitrate over the duration of one second. This comes at a cost in quality during high motion scenes or scenes with flickering brightness like often seen in RPGs.
Xaymar commented 2019-11-07 09:51:01 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

, mainly by disabling B-frames and using slice multithreading does not apply to NVENC unless you know how all NVENC chips work internally.

`, mainly by disabling B-frames and using slice multithreading` does not apply to NVENC unless you know how all NVENC chips work internally.
UserNaem commented 2019-11-10 00:45:46 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

I can't think of a good way to explain this myself, so I'll go with your description.

I can't think of a good way to explain this myself, so I'll go with your description.
NVENC.RateControl="Rate Control Options"
NVENC.RateControl.Mode="Mode"
Xaymar commented 2019-11-05 14:20:08 +01:00 (Migrated from github.com)
Review
Copy Link
Copy Source

Please split the description here up into NVENC.RateControl.Mode.XXX.Description, as having one huge description breaks the layout on smaller monitors or high DPI monitors.

Please split the description here up into NVENC.RateControl.Mode.XXX.Description, as having one huge description breaks the layout on smaller monitors or high DPI monitors.
NVENC.RateControl.Mode.Description="Rate control mode selection"
NVENC.RateControl.Mode.CQP="Constant Quantization Parameter"
NVENC.RateControl.Mode.CQP.Description="A flat compression ratio with no regard for bit rates."
NVENC.RateControl.Mode.VBR="Variable Bitrate"
NVENC.RateControl.Mode.VBR.Description="Sacrifices quality to stay below the upper bitrate limit,\nor saves bitrate where possible."
NVENC.RateControl.Mode.VBR_HQ="High Quality Variable Bitrate"
NVENC.RateControl.Mode.VBR_HQ.Description="Variable Bitrate with two-pass encoding enabled by default."
NVENC.RateControl.Mode.CBR="Constant Bitrate"
NVENC.RateControl.Mode.CBR.Description="Compresses footage so that it matches the target bitrate over the duration of\none second. This comes at a cost in quality during high motion scenes or\nscenes with flickering brightness like often seen in RPGs."
NVENC.RateControl.Mode.CBR_HQ="High Quality Constant Bitrate"
NVENC.RateControl.Mode.CBR_HQ.Description="Constant Bitrate with two-pass encoding enabled by default."
NVENC.RateControl.Mode.CBR_LD_HQ="Low Delay High Quality Constant Bitrate"
NVENC.RateControl.Mode.CBR_LD_HQ.Description="Constant Bitrate optimized for lowest encoding latency."
NVENC.RateControl.LookAhead="Look Ahead"
NVENC.RateControl.LookAhead.Description="Look ahead this many frames while encoding to better distribute bitrate.\nImproves quality slightly at the cost of some GPU time.\nSet to 0 to disable."
NVENC.RateControl.AdaptiveI="Enable adaptive I-Frame insertion"
8
 @@ -139,7 +152,7 @@ NVENC.AQ.Temporal="Enable Temporal Adaptive Quantization"
NVENC.AQ.Temporal.Description="Enable temporal adaptive quantization."
NVENC.Other="Other Options"
NVENC.Other.BFrames="Maximum B-Frames"
NVENC.Other.BFrames.Description="Maximum number of B-Frames to insert into the encoded bitstream.\nActual number of B-Frames may be lower depending on content and lookahead settings."
NVENC.Other.BFrames.Description="Maximum number of B-Frames to insert into the encoded bitstream.\nActual number of B-Frames may be lower depending on content and lookahead settings.\nOnly Turing NVENC supports B-Frames for HEVC."
NVENC.Other.BFrameReferenceMode="B-Frame Reference Mode"
NVENC.Other.BFrameReferenceMode.Each="Each B-Frame will be used for references"
NVENC.Other.BFrameReferenceMode.Middle="Only (# of B-Frames)/2 will be used for references"