xaymar/obs-ffmpeg-encoder
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 14 Wiki Activity

encoder: Fix width and height to use rescaled resolution #9

Merged
Xaymar merged 1 commits from patch-8 into master 2019-10-31 06:34:59 +01:00
Conversation 0 Commits 1 Files Changed 1
+2 -2
Xaymar commented 2019-10-31 06:29:40 +01:00 (Migrated from github.com)
Copy Link
Copy Source

Description

Fixes #8. Without this patch, all output stream would be in the base or output resolution defined in the video tab in OBS Studio.

Motivation and Context

Needed to stream at 720p and got a 1440p stream instead.

How Has This Been Tested?

Tested with recording downscaled HEVC.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Performance enhancement (non-breaking change which improves efficiency)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
### Description Fixes #8. Without this patch, all output stream would be in the base or output resolution defined in the video tab in OBS Studio. <!--- Describe your changes in detail. --> <!--- If this change includes UI elements, please include screenshots. --> ### Motivation and Context Needed to stream at 720p and got a 1440p stream instead. <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open Mantis issue, or implements feature request --> <!--- from the Ideas page, please link to the issue here. --> ### How Has This Been Tested? Tested with recording downscaled HEVC. <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment (hardware, OS version, etc.),--> <!--- and the tests you ran, including how it may affect other areas of code. --> ### Types of changes <!--- What types of changes does your PR introduce? Uncomment all that apply --> - Bug fix (non-breaking change which fixes an issue) <!--- - New feature (non-breaking change which adds functionality) --> - Performance enhancement (non-breaking change which improves efficiency) <!--- - Code cleanup (non-breaking change which makes code smaller or more readable) --> <!--- - Breaking change (fix or feature that would cause existing functionality to change) --> <!--- - Documentation (a change to documentation pages) --> ### Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] My code has been run through [clang-format](https://github.com/obsproject/obs-studio/blob/master/.clang-format). - [x] I have read the [**contributing** document](https://github.com/obsproject/obs-studio/blob/master/CONTRIBUTING.rst). - [x] My code is not on the master branch. - [x] The code has been tested. - [x] All commit messages are properly formatted and commits squashed where appropriate.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
good first issue
Good for newcomers
 status:duplicate
This issue or pull request already exists
 status:help wanted
Extra attention is needed
 status:invalid
This doesn't seem right
 status:wontfix
This will not be worked on
 type:bug
Functionality is broken to some degree.
 type:enhancement
New feature or request
 type:question
Generic questions about behavior and functionality.
 type:regression
Behavior that used to work and now doesn't.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
xaymar
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xaymar/obs-ffmpeg-encoder#9
Delete Branch "patch-8"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?