From 1b391c15573ac1302bd0cfaad9b0add3f7775f4c Mon Sep 17 00:00:00 2001 From: Cristobal E Date: Fri, 8 Nov 2019 15:20:00 -0600 Subject: [PATCH 1/2] Verbose error reporting on setting custom field values source/encoder.cpp: Added logic to print a clearer error text if the custom option can't be set and feedback if it can be set. --- source/encoder.cpp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/source/encoder.cpp b/source/encoder.cpp index f45f782..a4e1aae 100644 --- a/source/encoder.cpp +++ b/source/encoder.cpp @@ -1003,8 +1003,11 @@ bool obsffmpeg::encoder::update(obs_data_t* settings) if ((ret = av_opt_set(_context, key.c_str(), value.c_str(), AV_OPT_SEARCH_CHILDREN)) < 0) { - PLOG_WARNING("Option '%s' could not be set to '%s'.", - key.c_str(), value.c_str()); + char sterror[AV_ERROR_MAX_STRING_SIZE]; + av_make_error_string(sterror, AV_ERROR_MAX_STRING_SIZE, ret); + PLOG_WARNING("Option '%s' could not be set to '%s'. (%s)", key.c_str(), value.c_str(), sterror); + } else { + PLOG_WARNING("Option '%s' set to '%s'.", key.c_str(), value.c_str()); } have_param = false; have_key = false; -- 2.52.0 From 7cd6ed92334dbfb6b6268fa4c9afc2fe2734f853 Mon Sep 17 00:00:00 2001 From: Cristobal E Date: Mon, 11 Nov 2019 10:28:48 -0600 Subject: [PATCH 2/2] encoder.cpp: Removed warning message when an option was set correctly --- source/encoder.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/source/encoder.cpp b/source/encoder.cpp index a4e1aae..0556698 100644 --- a/source/encoder.cpp +++ b/source/encoder.cpp @@ -1006,8 +1006,6 @@ bool obsffmpeg::encoder::update(obs_data_t* settings) char sterror[AV_ERROR_MAX_STRING_SIZE]; av_make_error_string(sterror, AV_ERROR_MAX_STRING_SIZE, ret); PLOG_WARNING("Option '%s' could not be set to '%s'. (%s)", key.c_str(), value.c_str(), sterror); - } else { - PLOG_WARNING("Option '%s' set to '%s'.", key.c_str(), value.c_str()); } have_param = false; have_key = false; -- 2.52.0