ui/nvenc_hevc_handler: Add UI handler for NVENC HEVC

Even though property groups are supported in 23.x and above, there are quite a few bugs that result in completely bonkers behavior. So this function can be used to get the version of the currently running obs-studio.

.clang-format

@@ -67,7 +67,7 @@ BreakBeforeBraces: Custom
 BreakBeforeTernaryOperators: true
 BreakConstructorInitializers: BeforeColon
 #BreakInheritanceList: BeforeColon
-BreakStringLiterals: true
+BreakStringLiterals: false
 ConstructorInitializerAllOnOneLineOrOnePerLine: false
 Cpp11BracedListStyle: true
  

.github/FUNDING.yml

@@ -0,0 +1,3 @@
+issuehunt: xaymar
+patreon: xaymar
+custom: https://www.paypal.me/xaymar

.github/ISSUE_TEMPLATE/feature.md

@@ -0,0 +1,20 @@
+---
+name: Feature request
+about: Want a new feature implemented?
+
+---
+
+<!--- Please fill out the following template, which will help other contributors review your Issue. -->
+<!--- Make sure you’ve read the contribution guidelines -->
+
+### Description
+<!-- Describe the feature (and behavior) in as much detail as possible (yes, that means write an essay if you have to) -->
+<!-- Include images of what you expect from the feature -->
+
+### Checklist:
+<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
+<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
+- [ ] I have read the contribution guidelines.
+- [ ] This feature is necessary and can't be done through other means.
+- [ ] This feature does not break existing functionality.
+- [ ] I am willing to hire/pay someone to implement this.

.github/ISSUE_TEMPLATE/feedback.md

@@ -0,0 +1,27 @@
+---
+name: Question/Feedback
+about: Submit a question or some feedback! (Not for bugs, issues or crashes!)
+
+---
+
+<!--- Please fill out the following template, which will help other contributors review your Issue. -->
+<!--- Make sure you’ve read the contribution guidelines -->
+
+### Description
+<!-- Describe the feature (and behavior) in as much detail as possible (yes, that means write an essay if you have to) -->
+<!-- Include images of what you expect from the feature -->
+
+### System Information
+<!-- Include as much information about the system you're using as possible. -->
+- Software Version: [e. g. 1.0.0, 1.2.1, ... - NEVER LATEST]
+- Operating System: [e. g. Windows, Debian, Ubuntu, RedHat, FreeBSD, ...]
+- Kernel Version: [e. g. 1903/1809 (Windows), 4.12 (Linux), ...]
+- CPU: [e. g. Intel i7, AMD Zen2, Qualcomm, ...]
+- GPU: [e. g. Nvidia RTX 2xxx Series, AMD Radeone 5xxx Series, ...]
+- RAM: [e. g. 16GB, 32GB, 64GB, ...]
+
+### Checklist:
+<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
+<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
+- [ ] I have read the contribution guidelines.
+- [ ] This is not a bug, crash or generic issue.

.github/ISSUE_TEMPLATE/issue.md

@@ -0,0 +1,38 @@
+---
+name: Issue/Bug report
+about: Encountered a problem, a bug or a crash?
+
+---
+
+<!--- Please fill out the following template, which will help other contributors review your Issue. -->
+<!--- Make sure you’ve read the contribution guidelines -->
+
+### Description
+<!-- Describe the bug (and behavior) in as much detail as necessary -->
+<!-- Include screenshots and attach (crash) logs if possible -->
+
+### Expected Behavior
+<!-- What is the expected behavior in this case? -->
+
+### Reproduction Steps
+<!-- Describe the steps required to get this to happen from a cleanly installed obs-studio -->
+<!-- Leave out detail that is not relevant to  -->
+1. Open a portal to the Infinite Void
+2. Summon an ancient God
+3. Realize your mistake
+
+### System Information
+<!-- Include as much information about the system you're using as possible. -->
+- Software Version: [e. g. 1.0.0, 1.2.1, ... - NEVER LATEST]
+- Operating System: [e. g. Windows, Debian, Ubuntu, RedHat, FreeBSD, ...]
+- Kernel Version: [e. g. 1903/1809 (Windows), 4.12 (Linux), ...]
+- CPU: [e. g. Intel i7, AMD Zen2, Qualcomm, ...]
+- GPU: [e. g. Nvidia RTX 2xxx Series, AMD Radeone 5xxx Series, ...]
+- RAM: [e. g. 16GB, 32GB, 64GB, ...]
+
+### Checklist:
+<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
+<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
+- [ ] I have read the contribution guidelines.
+- [ ] I can reproduce the issue with the exact reproduction steps I have provided.
+- [ ] The issue appears on all of my systems that can run this software.

.github/pull_request_template.md

@@ -0,0 +1,35 @@
+<!--- Please fill out the following template, which will help other contributors review your Pull Request. -->
+
+<!--- Make sure you’ve read the contribution guidelines -->
+
+### Description
+<!--- Describe your changes in detail. -->
+<!--- If this change includes UI elements, please include screenshots. -->
+
+### Motivation and Context
+<!--- Why is this change required? What problem does it solve? -->
+<!--- If it fixes an open Mantis issue, or implements feature request -->
+<!--- from the Ideas page, please link to the issue here. -->
+
+### How Has This Been Tested?
+<!--- Please describe in detail how you tested your changes. -->
+<!--- Include details of your testing environment (hardware, OS version, etc.),-->
+<!--- and the tests you ran, including how it may affect other areas of code. -->
+
+### Types of changes
+<!--- What types of changes does your PR introduce? Uncomment all that apply -->
+<!--- - Bug fix (non-breaking change which fixes an issue) -->
+<!--- - New feature (non-breaking change which adds functionality) -->
+<!--- - Performance enhancement (non-breaking change which improves efficiency) -->
+<!--- - Code cleanup (non-breaking change which makes code smaller or more readable) -->
+<!--- - Breaking change (fix or feature that would cause existing functionality to change) -->
+<!--- - Documentation (a change to documentation pages) -->
+
+### Checklist:
+<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
+<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
+- [ ] My code has been run through [clang-format](https://github.com/obsproject/obs-studio/blob/master/.clang-format).
+- [ ] I have read the [**contributing** document](https://github.com/obsproject/obs-studio/blob/master/CONTRIBUTING.rst).
+- [ ] My code is not on the master branch.
+- [ ] The code has been tested.
+- [ ] All commit messages are properly formatted and commits squashed where appropriate.

CMakeLists.txt

@@ -1,5 +1,5 @@
-# A Plugin that integrates the AMD AMF encoder into OBS Studio
-# Copyright (C) 2016 - 2017 Michael Fabian Dirks
+# Integrates most FFmpeg supported encoders into OBS Studio
+# Copyright (C) 2018 - 2019 Michael Fabian Dirks
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -16,8 +16,8 @@
 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
 
 # CMake Setup
-cmake_minimum_required(VERSION 3.1.0)
-include("cmake/util.cmake")
+CMake_Minimum_Required(VERSION 3.8.0)
+Include("cmake/util.cmake")
 
 # Automatic Versioning
 set(VERSION_MAJOR 0)
@@ -50,15 +50,37 @@ if(EXISTS "${CMAKE_CURRENT_LIST_DIR}/.git")
 	endif()
 endif()
 
+# All Warnings, Extra Warnings, Pedantic
+if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
+	# using Clang
+	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wno-missing-braces -Wmissing-field-initializers -Wno-c++98-compat-pedantic -Wold-style-cast -Wno-documentation -Wno-documentation-unknown-command -Wno-covered-switch-default -Wno-switch-enum")
+elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
+	# GCC: -fpermissive is required as GCC does not allow the same template to be in different namespaces.
+	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wpedantic -fpermissive -Wno-long-long -Wno-missing-braces -Wmissing-field-initializers")
+elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Intel")
+	# using Intel C++
+elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC")
+	# Force to always compile with W4
+	if(CMAKE_CXX_FLAGS MATCHES "/W[0-4]")
+		string(REGEX REPLACE "/W[0-4]" "/W4" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
+	else()
+		set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /W4")
+	endif()
+endif()
+# C++ Standard and Extensions
+## Use C++17 and no non-standard extensions.
+set(_CXX_STANDARD 17)
+set(_CXX_EXTENSIONS OFF)
+
 # Define Project
 project(
-	enc-ffmpeg
+	obs-ffmpeg-encoder
 	VERSION ${VERSION_MAJOR}.${VERSION_MINOR}.${VERSION_PATCH}.${VERSION_TWEAK}
 )
 set(PROJECT_FULL_NAME "FFMPEG Encoder for OBS Studio")
-set(PROJECT_DESCRIPTION "Plugin for OBS Studio to add FFMPEG options for Recording and Streaming")
+set(PROJECT_DESCRIPTION "FFmpeg Encoders for OBS Studio")
 set(PROJECT_AUTHORS "Michael Fabian 'Xaymar' Dirks <info@xaymar.com>")
-set(PROJECT_COPYRIGHT_YEARS "2018")
+set(PROJECT_COPYRIGHT_YEARS "2018 - 2019")
 
 ################################################################################
 # Setup / Bootstrap
@@ -97,14 +119,14 @@ configure_file(
 )
 
 # Windows
-## Installer (InnoSetup)
-Configure_File(
+if (WIN32)
+	## Installer (InnoSetup)
+	configure_file(
 		"${PROJECT_SOURCE_DIR}/cmake/installer.iss.in"
 		"${PROJECT_BINARY_DIR}/installer.iss"
-)
+	)
 
-# Windows Specific Resource Definition
-if(WIN32)
+	# Windows Specific Resource Definition
 	set(PROJECT_PRODUCT_NAME "${PROJECT_FULL_NAME}")
 	set(PROJECT_COMPANY_NAME "${PROJECT_AUTHORS}")
 	set(PROJECT_COPYRIGHT "${PROJECT_AUTHORS} © ${PROJECT_COPYRIGHT_YEARS}")
@@ -118,19 +140,6 @@ if(WIN32)
 	)	
 endif()
 
-# All Warnings, Extra Warnings, Pedantic
-if(MSVC)
-	# Force to always compile with W4
-	if(CMAKE_CXX_FLAGS MATCHES "/W[0-4]")
-		string(REGEX REPLACE "/W[0-4]" "/W4" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
-	else()
-		set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /W4")
-	endif()
-elseif(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX)
-	# Update if necessary
-	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wno-long-long -pedantic")
-endif()
-
 ################################################################################
 # Options
 ################################################################################
@@ -142,7 +151,7 @@ mark_as_advanced(FORCE OBS_NATIVE OBS_PACKAGE OBS_REFERENCE OBS_DOWNLOAD)
 
 if(NOT TARGET libobs)
 	set(${PropertyPrefix}OBS_STUDIO_DIR "" CACHE PATH "OBS Studio Source/Package Directory")
-	set(${PropertyPrefix}OBS_DOWNLOAD_VERSION "22.0.2" CACHE STRING "OBS Studio Version to download")
+	set(${PropertyPrefix}OBS_DOWNLOAD_VERSION "23.2.1-ci" CACHE STRING "OBS Studio Version to download")
 endif()
 
 if(NOT ${PropertyPrefix}OBS_NATIVE)
@@ -171,7 +180,7 @@ else()
 	else()
 		message(STATUS "${PROJECT_NAME}: No OBS Studio detected, using downloadable prebuilt binaries.")
 		CacheSet(${PropertyPrefix}OBS_DOWNLOAD TRUE)
-		set(${PropertyPrefix}OBS_DOWNLOAD_URL "https://github.com/Xaymar/obs-studio/releases/download/${OBS_DOWNLOAD_VERSION}/obs-studio-${ARCH}-vs2017.7z")
+		set(${PropertyPrefix}OBS_DOWNLOAD_URL "https://github.com/Xaymar/obs-studio/releases/download/${OBS_DOWNLOAD_VERSION}/obs-studio-${ARCH}-0.0.0.0-vs2017.7z")
 	endif()
 endif()
 
@@ -179,17 +188,9 @@ endif()
 if(${PropertyPrefix}OBS_DOWNLOAD)
 	include("cmake/DownloadProject.cmake")
 endif()
-if(NOT ${PropertyPrefix}OBS_NATIVE)
-	include("cmake/cppcheck.cmake")
-endif()
 
 # Load OBS Studio
 if(${PropertyPrefix}OBS_NATIVE)
-	option(BUILD_FFMPEG_ENCODER "Build AMD Encoder module" ON)	
-	if (NOT BUILD_FFMPEG_ENCODER)
-		message(STATUS "Not building AMD Encoder")
-		return()
-	endif()
 elseif(${PropertyPrefix}OBS_PACKAGE)
 	include("${OBS_STUDIO_DIR}/cmake/LibObs/LibObsConfig.cmake")
 elseif(${PropertyPrefix}OBS_REFERENCE)
@@ -203,7 +204,7 @@ elseif(${PropertyPrefix}OBS_DOWNLOAD)
 	)
 	include("${libobs_SOURCE_DIR}/cmake/LibObs/LibObsConfig.cmake")
 else()
-	message(CRITICAL "Impossible case reached, very system stability.")
+	message(CRITICAL "Impossible case reached, verify system stability.")
 	return()
 endif()
 
@@ -232,6 +233,29 @@ find_package(FFmpeg REQUIRED COMPONENTS avutil avcodec swscale)
 ################################################################################
 # Code
 ################################################################################
+set(PROJECT_DATA
+	"${PROJECT_SOURCE_DIR}/data/locale/en-US.ini"
+	"${PROJECT_SOURCE_DIR}/LICENSE"
+)
+
+set(PROJECT_LIBRARIES
+)
+
+set(PROJECT_TEMPLATES
+	"${PROJECT_SOURCE_DIR}/cmake/version.hpp.in"
+	"${PROJECT_SOURCE_DIR}/cmake/module.cpp.in"	
+)
+if(WIN32)
+	list(APPEND PROJECT_TEMPLATES
+		"${PROJECT_SOURCE_DIR}/cmake/installer.iss.in"
+		"${PROJECT_SOURCE_DIR}/cmake/version.rc.in"
+	)
+endif()
+
+set(PROJECT_GENERATED
+	"${PROJECT_BINARY_DIR}/source/module.cpp"
+	"${PROJECT_BINARY_DIR}/source/version.hpp"
+)
 set(PROJECT_PRIVATE
 	"${PROJECT_SOURCE_DIR}/source/encoder.cpp"
 	"${PROJECT_SOURCE_DIR}/source/encoder.hpp"
@@ -239,6 +263,11 @@ set(PROJECT_PRIVATE
 	"${PROJECT_SOURCE_DIR}/source/plugin.hpp"
 	"${PROJECT_SOURCE_DIR}/source/utility.cpp"
 	"${PROJECT_SOURCE_DIR}/source/utility.hpp"
+	"${PROJECT_SOURCE_DIR}/source/strings.hpp"
+	"${PROJECT_SOURCE_DIR}/source/codecs/hevc.hpp"
+	"${PROJECT_SOURCE_DIR}/source/codecs/hevc.cpp"
+	"${PROJECT_SOURCE_DIR}/source/encoders/generic.hpp"
+	"${PROJECT_SOURCE_DIR}/source/encoders/generic.cpp"
 	"${PROJECT_SOURCE_DIR}/source/encoders/prores_aw.hpp"
 	"${PROJECT_SOURCE_DIR}/source/encoders/prores_aw.cpp"
 	"${PROJECT_SOURCE_DIR}/source/ffmpeg/avframe-queue.cpp"
@@ -247,22 +276,32 @@ set(PROJECT_PRIVATE
 	"${PROJECT_SOURCE_DIR}/source/ffmpeg/swscale.cpp"
 	"${PROJECT_SOURCE_DIR}/source/ffmpeg/tools.hpp"
 	"${PROJECT_SOURCE_DIR}/source/ffmpeg/tools.cpp"
-)
-SET(PROJECT_GENERATED
-	"${PROJECT_BINARY_DIR}/source/module.cpp"
-	"${PROJECT_BINARY_DIR}/source/version.hpp"
-)
-set(PROJECT_DATA
-	"${PROJECT_SOURCE_DIR}/data/locale/en-US.ini"
-	"${PROJECT_SOURCE_DIR}/LICENSE"
-)
-set(PROJECT_LIBRARIES
+	"${PROJECT_SOURCE_DIR}/source/ui/handler.hpp"
+	"${PROJECT_SOURCE_DIR}/source/ui/handler.cpp"
+	"${PROJECT_SOURCE_DIR}/source/ui/debug_handler.hpp"
+	"${PROJECT_SOURCE_DIR}/source/ui/debug_handler.cpp"
+	"${PROJECT_SOURCE_DIR}/source/ui/prores_aw_handler.hpp"
+	"${PROJECT_SOURCE_DIR}/source/ui/prores_aw_handler.cpp"
+	"${PROJECT_SOURCE_DIR}/source/ui/nvenc_shared.hpp"
+	"${PROJECT_SOURCE_DIR}/source/ui/nvenc_shared.cpp"
+	"${PROJECT_SOURCE_DIR}/source/ui/nvenc_hevc_handler.hpp"
+	"${PROJECT_SOURCE_DIR}/source/ui/nvenc_hevc_handler.cpp"
 )
 
 # Source Grouping
 source_group(TREE "${PROJECT_SOURCE_DIR}" PREFIX "Data Files" FILES ${PROJECT_DATA})
-source_group(TREE "${PROJECT_SOURCE_DIR}/source" PREFIX "Private Files" FILES ${PROJECT_PRIVATE})
 source_group(TREE "${PROJECT_BINARY_DIR}/source" PREFIX "Generated Files" FILES ${PROJECT_GENERATED})
+source_group(TREE "${PROJECT_SOURCE_DIR}/cmake" PREFIX "Template Files" FILES ${PROJECT_TEMPLATES})
+
+# Filter Sources
+set(_TMP_SOURCE ${PROJECT_PRIVATE})
+list(FILTER _TMP_SOURCE INCLUDE REGEX "\.(c|cpp)$")
+source_group(TREE "${PROJECT_SOURCE_DIR}/source" PREFIX "Source Files" FILES ${_TMP_SOURCE})
+
+# Filter Headers
+set(_TMP_HEADER ${PROJECT_PRIVATE})
+list(FILTER _TMP_HEADER INCLUDE REGEX "\.(h|hpp)$")
+source_group(TREE "${PROJECT_SOURCE_DIR}/source" PREFIX "Header Files" FILES ${_TMP_HEADER})
 
 ################################################################################
 # Target
@@ -367,6 +406,14 @@ if (WIN32)
 	)
 endif()
 
+# C++ Standard and Extensions
+set_target_properties(
+	${PROJECT_NAME}
+	PROPERTIES
+		CXX_STANDARD ${_CXX_STANDARD}
+		CXX_EXTENSIONS ${_CXX_EXTENSIONS}
+)
+
 # File Version
 if(WIN32)
 	set_target_properties(
@@ -384,24 +431,6 @@ else()
 	)
 endif()
 
-# CPPCheck
-if(NOT ${PropertyPrefix}OBS_NATIVE)
-	set(excludes )
-	list(APPEND excludes "${OBS_DEPENDENCIES_DIR}")
-	if(${PropertyPrefix}OBS_REFERENCE)
-		list(APPEND excludes "${OBS_STUDIO_DIR}/libobs")
-	elseif(${PropertyPrefix}OBS_PACKAGE)
-		list(APPEND excludes "${OBS_STUDIO_DIR}/libobs")
-	elseif(${PropertyPrefix}OBS_DOWNLOAD)
-		list(APPEND excludes "${libobs_SOURCE_DIR}")
-	endif()
-
-	cppcheck(
-		EXCLUDE ${excludes}
-	)
-	cppcheck_add_project(${PROJECT_NAME})
-endif()
-
 ################################################################################
 # Installation
 ################################################################################

appveyor.yml

@@ -1,43 +1,49 @@
+# Generic Settings
 version: '{build}-{branch}'
-pull_requests:
-  do_not_increment_build_number: true
 
 matrix:
   fast_finish: true
 
+# Build Image & Environment
 platform: x64
-image: Visual Studio 2017
-environment:
-  CMAKE_SYSTEM_VERSION: 10.0.16299.91
-  PACKAGE_PREFIX: obs-ffmpeg-encoder
-  INNOSETUP_URL: http://www.jrsoftware.org/download.php/is-unicode.exe
 
+image:
+  - Visual Studio 2017
+
+environment:
+  CMAKE_SYSTEM_VERSION: 10.0.17134.0
+  PACKAGE_PREFIX: obs-ffmpeg-encoder
+  INNOSETUP_URL: http://www.jrsoftware.org/download.php/is.exe
+  CURL_VERSION: 7.39.0
+
+# Resource Cache
+cache:
+  - inno.exe
+  - build/32/libobs-download
+  - build/32/libobs-src
+  - build/64/libobs-download
+  - build/64/libobs-src
+
+# Building  
 install:
 - cmd: ci/appveyor-install.bat
 
 build_script:
-- cmd: ci/appveyor-build.bat
+- cmd: node ci/appveyor-build.js
 
 after_build:
 - cmd: ci/appveyor-package.bat
 
-cache:
-  - inno.exe
-  - build/32/obsdeps-build
-  - build/32/obsdeps-download
-  - build/32/obsdeps-src
-  - build/32/libobs-build
-  - build/32/libobs-download
-  - build/32/libobs-src
-  - build/64/libobs-build
-  - build/64/libobs-download
-  - build/64/libobs-src
+# Testing
+test: off
 
+# Artifacts
 artifacts:
   - path: build/obs-ffmpeg-encoder-*.zip
   - path: build/obs-ffmpeg-encoder-*.7z
   - path: build/obs-ffmpeg-encoder-*.exe
 
+# Deploying
 deploy:
   - provider: GitHub
     auth_token:
@@ -48,4 +54,15 @@ deploy:
     on:
       appveyor_repo_tag: true
 
-test: off
+# Notifications
+notifications:
+  - provider: Webhook
+    url: 
+      secure: PTtt5ALhmK0q42jYyx4/Qa1Uf18+gLMXKGdzJjDISJt8IE/K0Zyp58UYmDDbbyLp4pBRf/Ylj8rn/zYL/mqBoDVRIH5zasPqIvBD0ZhtvNjTOxQ3QoRkAmxgpWeMowm3A3I1rLizA2H4EctPpoAJGrvQ1G2HEYn9tVsGYeetFTo=
+    on_build_success: false
+    on_build_failure: false
+    on_build_status_changed: true
+    body: >-
+      {
+        "content": "**Build {{status}}**: [{{commitId}}] {{commitMessage}}\nBy {{commitAuthor}} on {{commitDate}}\n{{buildUrl}}"
+      }

ci/appveyor-build.bat

@@ -1,4 +0,0 @@
-cmake -H. -B"build/32" -G"Visual Studio 15 2017" -DCMAKE_INSTALL_PREFIX="%CD%/build/distrib" -DCMAKE_PACKAGE_PREFIX="%CD%/build" -DCMAKE_PACKAGE_NAME="obs-ffmpeg-encoder"
-cmake -H. -B"build/64" -G"Visual Studio 15 2017 Win64" -T"host=x64" -DCMAKE_INSTALL_PREFIX="%CD%/build/distrib" -DCMAKE_PACKAGE_PREFIX="%CD%/build" -DCMAKE_PACKAGE_NAME="obs-ffmpeg-encoder" -DOBS_DEPENDENCIES_DIR="%CD%/build/32/obsdeps-src"
-cmake --build build/32 --target INSTALL --config RelWithDebInfo -- /logger:"C:\Program Files\AppVeyor\BuildAgent\Appveyor.MSBuildLogger.dll"
-cmake --build build/64 --target INSTALL --config RelWithDebInfo -- /logger:"C:\Program Files\AppVeyor\BuildAgent\Appveyor.MSBuildLogger.dll"

ci/appveyor-build.js

@@ -0,0 +1,98 @@
+const cp = require('child_process');
+
+var config32 = cp.spawn(
+	"cmake", [
+		'-H.',
+		'-B"build/32"',
+		'-G"Visual Studio 15 2017"',
+		'-DCMAKE_INSTALL_PREFIX="build/distrib"',
+		'-DCMAKE_PACKAGE_PREFIX="build"',
+		'-DCMAKE_PACKAGE_NAME="xmr-ffmpeg-encoders"'
+	], {
+		windowsVerbatimArguments: true,
+		windowsHide: true
+	}
+);
+config32.stdout.on('data', (data) => {
+	process.stdout.write(`[32:Out] ${data}`);
+});
+config32.stderr.on('data', (data) => {
+	console.log(`[32:Err] ${data}`);
+});
+config32.on('exit', (code, signal) => {
+	if (code != 0) {
+		process.exit(code)
+	}
+	var build32 = cp.spawn(
+		"cmake", [
+			'--build build/32',
+			'--target INSTALL',
+			'--config RelWithDebInfo',
+			'--',
+			'/logger:"C:\\Program Files\\AppVeyor\\BuildAgent\\Appveyor.MSBuildLogger.dll"'
+		], {
+			windowsVerbatimArguments: true,
+			windowsHide: true
+		}
+	);
+	build32.stdout.on('data', (data) => {
+		process.stdout.write(`[32:Out] ${data}`);
+	});
+	build32.stderr.on('data', (data) => {
+		process.stderr.write(`[32:Err] ${data}`);
+	});
+	build32.on('exit', (code, signal) => {
+		if (code != 0) {
+			process.exit(code)
+		}
+	});
+});
+
+var config64 = cp.spawn(
+	"cmake", [
+		'-H.',
+		'-B"build/64"',
+		'-G"Visual Studio 15 2017 Win64"',
+		'-DCMAKE_INSTALL_PREFIX="build/distrib"',
+		'-DCMAKE_PACKAGE_PREFIX="build"',
+		'-DCMAKE_PACKAGE_NAME="xmr-ffmpeg-encoders"'
+	], {
+		windowsVerbatimArguments: true,
+		windowsHide: true
+	}
+);
+config64.stdout.on('data', (data) => {
+	process.stdout.write(`[64:Out] ${data}`);
+});
+config64.stderr.on('data', (data) => {
+	console.log(`[64:Err] ${data}`);
+});
+config64.on('exit', (code, signal) => {
+	if (code != 0) {
+		process.exit(code)
+	}
+	var build64 = cp.spawn(
+		"cmake", [
+			'--build build/64',
+			'--target INSTALL',
+			'--config RelWithDebInfo',
+			'--',
+			'/logger:"C:\\Program Files\\AppVeyor\\BuildAgent\\Appveyor.MSBuildLogger.dll"'
+		], {
+			windowsVerbatimArguments: true,
+			windowsHide: true
+		}
+	);
+	build64.stdout.on('data', (data) => {
+		process.stdout.write(`[32:Out] ${data}`);
+	});
+	build64.stderr.on('data', (data) => {
+		process.stderr.write(`[32:Err] ${data}`);
+	});
+	build64.on('exit', (code, signal) => {
+		if (code != 0) {
+			process.exit(code)
+		}
+	});
+});
+

ci/appveyor-install.bat

@@ -1,3 +1,4 @@
+@ECHO OFF
 git submodule update --init --force --recursive
 
 IF EXIST inno.exe (

ci/appveyor-package.bat

@@ -1,3 +1,4 @@
+@ECHO OFF
 ECHO -- Building 7z Archive --
 cmake --build build/64 --target PACKAGE_7Z --config RelWithDebInfo
 ECHO -- Building Zip Archive --

data/locale/en-US.ini

@@ -1,15 +1,128 @@
-Bitrate="Bitrate"
-Bitrate.Description="Bitrate in kbit/s"
-KeyFrame.Type="Key Frame Type"
-KeyFrame.Type.Frames="Frames"
-KeyFrame.Type.Seconds="Seconds"
-KeyFrame.Interval="Key Frame Interval"
-KeyFrame.Interval.Description="Interval in which a Key Frame is placed."
-CustomParameters="Custom Parameters"
-CustomParameters.Description="Format: key1=val1 key2=val2 key3='val3 val4'"
+# Generic
+State.Automatic="Automatic"
+State.Default="Default"
+State.Disabled="Disabled"
+State.Enabled="Enabled"
+State.Manual="Manual"
+
+# FFmpeg
+FFmpeg="FFmpeg Options"
+FFmpeg.CustomSettings="Custom Settings"
+FFmpeg.CustomSettings.Description="Custom settings that override any detected options above, use with caution.\nThe input should be in the format 'key=value;key=value;...'."
+FFmpeg.Threads="Number of Threads"
+FFmpeg.Threads.Description="The number of threads to use for encoding, if supported by the encoder.\nA value of 0 is equal to 'auto-detect' and may result in excessive CPU usage."
+FFmpeg.ColorFormat="Override Color Format"
+FFmpeg.ColorFormat.Description="Overriding the color format can unlock higher quality, but might cause additional stress.\nNot all encoders support all color formats, and you might end up causing errors or corrupted video due to this."
+FFmpeg.StandardCompliance="Standard Compliance"
+FFmpeg.StandardCompliance.Description="How strict should the encoder keep to the standard? A strictness below 'Normal' may cause issues with playback."
+FFmpeg.StandardCompliance.VeryStrict="Very Strict"
+FFmpeg.StandardCompliance.Strict="Strict"
+FFmpeg.StandardCompliance.Normal="Normal"
+FFmpeg.StandardCompliance.Unofficial="Unofficial"
+FFmpeg.StandardCompliance.Experimental="Experimental"
+
+# Rate Control
+RateControl="Rate Control"
+RateControl.Mode="Method"
+RateControl.Mode.ConstantBitrate="Constant Bitrate"
+RateControl.Mode.AverageBitrate="Average Bitrate"
+RateControl.Mode.VariableBitrate="Variable Bitrate"
+RateControl.Mode.ConstantQuantizationParameter="Constant Quantization Parameter"
+RateControl.Mode.ConstantRateFactor="Constant Rate Factor"
+RateControl.Mode.ConstantQuality="Constant Quality"
+RateControl.Mode.VariableQuality="Variable Quality"
+RateControl.Mode.Lossless="Lossless"
+RateControl.Bitrate.Target="Target Bitrate"
+RateControl.Bitrate.Minimum="Minimum Bitrate"
+RateControl.Bitrate.Maximum="Maximum Bitrate"
+RateControl.Quality.Target="Target Quality"
+RateControl.Quality.Minimum="Minimum Quality"
+RateControl.Quality.Maximum="Maximum Quality"
+RateControl.BufferSize="Buffer Size"
+
+# Key Frames
+KeyFrames="Key Frames"
+KeyFrames.IntervalType="Interval Type"
+KeyFrames.IntervalType.Frames="Frames"
+KeyFrames.IntervalType.Seconds="Seconds"
+KeyFrames.Interval="Interval"
+
+# Apple ProRes
+AppleProRes.Profile="Profile"
+AppleProRes.Profile.APCO="Proxy"
+AppleProRes.Profile.APCS="LT"
+AppleProRes.Profile.APCN="Standard Definition"
+AppleProRes.Profile.APCH="High Quality"
+AppleProRes.Profile.AP4H="4444"
 
 # ProRes
 ProRes.Profile.Proxy="Proxy (PXY)"
 ProRes.Profile.Light="Light (LT)"
 ProRes.Profile.Standard="Standard"
 ProRes.Profile.HighQuality="High Quality (HQ)"
+
+# Codec: HEVC
+Codec.HEVC="HEVC"
+Codec.HEVC.Profile="Profile"
+Codec.HEVC.Profile.main="Main"
+Codec.HEVC.Profile.main10="Main 10-bit"
+Codec.HEVC.Profile.rext="Range Extended"
+Codec.HEVC.Tier="Tier"
+Codec.HEVC.Tier.main="Main"
+Codec.HEVC.Tier.high="High"
+Codec.HEVC.Level="Level"
+
+# NVENC
+NVENC.Preset="Preset"
+NVENC.Preset.Default="Default"
+NVENC.Preset.Slow="Slow"
+NVENC.Preset.Medium="Medium"
+NVENC.Preset.Fast="Fast"
+NVENC.Preset.HighPerformance="High Performance"
+NVENC.Preset.HighQuality="High Quality"
+NVENC.Preset.BluRayDisc="BluRay Disc"
+NVENC.Preset.LowLatency="Low Latency"
+NVENC.Preset.LowLatencyHighPerformance="Low Latency High Performance"
+NVENC.Preset.LowLatencyHighQuality="Low Latency High Quality"
+NVENC.Preset.Lossless="Lossless"
+NVENC.Preset.LosslessHighPerformance="Lossless High Performance"
+NVENC.RateControl="Rate Control Options"
+NVENC.RateControl.Mode="Mode"
+NVENC.RateControl.Mode.CQP="Constant Quantization Parameter"
+NVENC.RateControl.Mode.VBR="Variable Bitrate"
+NVENC.RateControl.Mode.VBR_HQ="High Quality Variable Bitrate"
+NVENC.RateControl.Mode.CBR="Constant Bitrate"
+NVENC.RateControl.Mode.CBR_HQ="High Quality Constant Bitrate"
+NVENC.RateControl.Mode.CBR_LD_HQ="Low Delay High Quality Constant Bitrate"
+NVENC.RateControl.LookAhead="Look Ahead"
+NVENC.RateControl.LookAhead.Description="Look ahead this many frames while encoding to better distribute bitrate.\nImproves quality slightly at the cost of some GPU time.\nSet to 0 to disable."
+NVENC.RateControl.AdaptiveI="Enable adaptive I-Frame insertion"
+NVENC.RateControl.AdaptiveI.Description="Enables adaptive I-Frame insertion.\nOnly has an effect when look ahead is set to a value other than 0."
+NVENC.RateControl.AdaptiveB="Enable adaptive B-Frame insertion"
+NVENC.RateControl.AdaptiveB.Description="Enables adaptive B-Frame insertion.\nOnly has an effect when look ahead is set to a value other than 0."
+NVENC.RateControl.TwoPass="Enable Two Pass"
+NVENC.RateControl.TwoPass.Description="Enable a secondary pass for encoding, which can help with quality and bitrate stability.\nImproves quality slightly at the cost of some GPU time.\nNvidia Turing hardware might actually see a quality degrade from this."
+NVENC.RateControl.Bitrate="Bitrate Limits"
+NVENC.RateControl.Bitrate.Target="Target Bitrate"
+NVENC.RateControl.Bitrate.Maximum="Maximum Bitrate"
+NVENC.RateControl.Quality="Enable Quality Limits"
+NVENC.RateControl.Quality.Minimum="Minimum"
+NVENC.RateControl.Quality.Minimum.Description="Minimum quality to achieve, with values closer to 0 being better quality."
+NVENC.RateControl.Quality.Maximum="Maximum"
+NVENC.RateControl.Quality.Maximum.Description="Maximum quality to achieve, with values closer to 0 being better quality.\nSet to -1 to disable the maximum restriction."
+NVENC.AQ="Adaptive Quantization"
+NVENC.AQ.Spatial="Enable Spatial Adaptive Quantization"
+NVENC.AQ.Strength="Spatial AQ Strength"
+NVENC.AQ.Strength.Description="Strength of the spatial adaptive quantization.\nValues closer to 15 mean more aggressive, while values closer to 1 mean more relaxed."
+NVENC.AQ.Temporal="Enable Temporal Adaptive Quantization"
+NVENC.Other="Other Options"
+NVENC.Other.BFrames="Maximum B-Frames"
+NVENC.Other.BFrameReferenceMode="B-Frame Reference Mode"
+NVENC.Other.BFrameReferenceMode.Each="Each B-Frame will be used for references"
+NVENC.Other.BFrameReferenceMode.Middle="Only (# of B-Frames)/2 will be used for references"
+NVENC.Other.ZeroLatency="Enable Zero Latency"
+NVENC.Other.ZeroLatency.Description="Enable zero latency operation, which ensures that there is no reordering delay."
+NVENC.Other.WeightedPrediction="Enable Weighted Prediction"
+NVENC.Other.WeightedPrediction.Description="Enable weighted prediction for encoding.\nCan't be used with B-Frames."
+NVENC.Other.NonReferencePFrames="Enable non-reference P-Frames"
+NVENC.Other.NonReferencePFrames.Description="Enable the automatic insertion of non-reference P-Frames."

source/codecs/hevc.cpp

@@ -0,0 +1,37 @@
+// FFMPEG Video Encoder Integration for OBS Studio
+// Copyright (C) 2018 - 2019 Michael Fabian Dirks
+//
+// This program is free software; you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation; either version 2 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program; if not, write to the Free Software
+// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+
+#include "hevc.hpp"
+
+using namespace obsffmpeg::codecs::hevc;
+
+std::map<profile, std::string> obsffmpeg::codecs::hevc::profiles{
+    {profile::MAIN, "main"},
+    {profile::MAIN10, "main10"},
+    {profile::RANGE_EXTENDED, "rext"},
+};
+
+std::map<tier, std::string> obsffmpeg::codecs::hevc::profile_tiers{
+    {tier::MAIN, "main"},
+    {tier::HIGH, "high"},
+};
+
+std::map<level, std::string> obsffmpeg::codecs::hevc::levels{
+    {level::L1_0, "1.0"}, {level::L2_0, "2.0"}, {level::L3_0, "3.0"}, {level::L3_1, "3.1"},
+    {level::L4_0, "4.0"}, {level::L4_1, "4.1"}, {level::L5_0, "5.0"}, {level::L5_1, "5.1"},
+    {level::L5_2, "5.2"}, {level::L6_0, "6.0"}, {level::L6_1, "6.1"}, {level::L6_2, "6.2"},
+};

source/codecs/hevc.hpp

@@ -0,0 +1,67 @@
+// FFMPEG Video Encoder Integration for OBS Studio
+// Copyright (C) 2018 - 2019 Michael Fabian Dirks
+//
+// This program is free software; you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation; either version 2 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program; if not, write to the Free Software
+// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+
+#pragma once
+#include <map>
+
+// Codec: HEVC
+#define P_HEVC "Codec.HEVC"
+#define P_HEVC_PROFILE "Codec.HEVC.Profile"
+#define P_HEVC_TIER "Codec.HEVC.Tier"
+#define P_HEVC_LEVEL "Codec.HEVC.Level"
+
+namespace obsffmpeg {
+	namespace codecs {
+		namespace hevc {
+			enum class profile {
+				MAIN,
+				MAIN10,
+				RANGE_EXTENDED,
+				UNKNOWN = -1,
+			};
+
+			enum class tier {
+				MAIN,
+				HIGH,
+				UNKNOWN = -1,
+			};
+
+			enum class level {
+				L1_0    = 30,
+				L2_0    = 60,
+				L3_0    = 90,
+				L3_1    = 93,
+				L4_0    = 120,
+				L4_1    = 123,
+				L5_0    = 150,
+				L5_1    = 153,
+				L5_2    = 156,
+				L6_0    = 180,
+				L6_1    = 183,
+				L6_2    = 186,
+				UNKNOWN = -1,
+			};
+
+			extern std::map<profile, std::string> profiles;
+
+			extern std::map<tier, std::string> profile_tiers;
+
+			extern std::map<level, std::string> levels;
+
+		} // namespace hevc
+	}         // namespace codecs
+} // namespace obsffmpeg

source/encoder.hpp

@@ -124,7 +124,7 @@ namespace obsffmpeg {
 	{ \
 		_source##_info.id             = "obs-ffmpeg-encoder-" #_source; \
 		_source##_info.type           = OBS_ENCODER_VIDEO; \
-		_source##_info.caps           = 0; \
+		_source##_info.caps           = OBS_ENCODER_CAP_DEPRECATED; \
 		_source##_info.codec          = _codec; \
 		_source##_info.create         = _source##_create; \
 		_source##_info.destroy        = _source##_destroy; \

source/encoders/generic.cpp

@@ -0,0 +1,721 @@
+// FFMPEG Video Encoder Integration for OBS Studio
+// Copyright (C) 2018 - 2019 Michael Fabian Dirks
+//
+// This program is free software; you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation; either version 2 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program; if not, write to the Free Software
+// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+
+#include "generic.hpp"
+#include <iomanip>
+#include <sstream>
+#include <thread>
+#include <util/profiler.hpp>
+#include "ffmpeg/tools.hpp"
+#include "plugin.hpp"
+#include "utility.hpp"
+
+extern "C" {
+#include <obs-module.h>
+#pragma warning(push)
+#pragma warning(disable : 4244)
+#include <libavutil/dict.h>
+#include <libavutil/frame.h>
+#include <libavutil/opt.h>
+#include <libavutil/pixdesc.h>
+#pragma warning(pop)
+}
+
+// Generic
+#define P_AUTOMATIC "Automatic"
+
+// FFmpeg
+#define P_FFMPEG "FFmpeg"
+#define P_FFMPEG_CUSTOMSETTINGS "FFmpeg.CustomSettings"
+#define P_FFMPEG_THREADS "FFmpeg.Threads"
+#define P_FFMPEG_COLORFORMAT "FFmpeg.ColorFormat"
+#define P_FFMPEG_STANDARDCOMPLIANCE "FFmpeg.StandardCompliance"
+
+enum class keyframe_type { Seconds, Frames };
+
+encoder::generic_factory::generic_factory(AVCodec* codec) : avcodec_ptr(codec), info() {}
+
+encoder::generic_factory::~generic_factory() {}
+
+void encoder::generic_factory::register_encoder()
+{
+	// Generate unique name from given Id
+	{
+		std::stringstream sstr;
+		sstr << "ffmpeg-" << avcodec_ptr->name << "-0x" << std::uppercase << std::setfill('0') << std::setw(8)
+		     << std::hex << avcodec_ptr->capabilities;
+		this->info.uid = sstr.str();
+	}
+
+	// Also generate a human readable name while we're at it.
+	// TODO: Figure out a way to translate from names to other names.
+	{
+		std::stringstream sstr;
+		sstr << (avcodec_ptr->long_name ? avcodec_ptr->long_name : avcodec_ptr->name) << " ("
+		     << avcodec_ptr->name << ")";
+		std::string caps = ffmpeg::tools::translate_encoder_capabilities(avcodec_ptr->capabilities);
+		if (caps.length() != 0) {
+			sstr << " [" << caps << "]";
+		}
+		this->info.readable_name = sstr.str();
+	}
+
+	// Assign Ids.
+	{
+		const AVCodecDescriptor* desc = avcodec_descriptor_get(this->avcodec_ptr->id);
+		if (desc) {
+			this->info.codec = desc->name;
+		} else {
+			this->info.codec = avcodec_ptr->name;
+		}
+	}
+	this->info.oei.id    = this->info.uid.c_str();
+	this->info.oei.codec = this->info.codec.c_str();
+
+	// Is this a deprecated encoder?
+#ifndef _DEBUG
+	if (!obsffmpeg::has_codec_handler(avcodec_ptr->name)) {
+		this->info.oei.caps |= OBS_ENCODER_CAP_DEPRECATED;
+	}
+#endif
+
+	// Detect encoder type (only Video and Audio supported)
+	if (avcodec_ptr->type == AVMediaType::AVMEDIA_TYPE_VIDEO) {
+		this->info.oei.type = obs_encoder_type::OBS_ENCODER_VIDEO;
+	} else if (avcodec_ptr->type == AVMediaType::AVMEDIA_TYPE_AUDIO) {
+		this->info.oei.type = obs_encoder_type::OBS_ENCODER_AUDIO;
+	} else {
+		throw std::invalid_argument("unsupported codec type");
+	}
+
+	// Register functions.
+	this->info.oei.create = [](obs_data_t* settings, obs_encoder_t* encoder) {
+		try {
+			return reinterpret_cast<void*>(new generic(settings, encoder));
+		} catch (std::exception const& e) {
+			PLOG_ERROR("exception: %s", e.what());
+			return reinterpret_cast<void*>(0);
+		} catch (...) {
+			PLOG_ERROR("unknown exception");
+			return reinterpret_cast<void*>(0);
+		}
+	};
+	this->info.oei.destroy = [](void* ptr) {
+		try {
+			delete reinterpret_cast<generic*>(ptr);
+		} catch (std::exception const& e) {
+			PLOG_ERROR("exception: %s", e.what());
+			throw e;
+		} catch (...) {
+			PLOG_ERROR("unknown exception");
+			throw;
+		}
+	};
+	this->info.oei.get_name = [](void* type_data) {
+		try {
+			return reinterpret_cast<generic_factory*>(type_data)->get_name();
+		} catch (std::exception const& e) {
+			PLOG_ERROR("exception: %s", e.what());
+			throw e;
+		} catch (...) {
+			PLOG_ERROR("unknown exception");
+			throw;
+		}
+	};
+	this->info.oei.get_defaults2 = [](obs_data_t* settings, void* type_data) {
+		try {
+			reinterpret_cast<generic_factory*>(type_data)->get_defaults(settings);
+		} catch (std::exception const& e) {
+			PLOG_ERROR("exception: %s", e.what());
+			throw e;
+		} catch (...) {
+			PLOG_ERROR("unknown exception");
+			throw;
+		}
+	};
+	this->info.oei.get_properties2 = [](void* ptr, void* type_data) {
+		try {
+			obs_properties_t* props = obs_properties_create();
+			if (type_data != nullptr) {
+				reinterpret_cast<generic_factory*>(type_data)->get_properties(props);
+			}
+			if (ptr != nullptr) {
+				reinterpret_cast<generic*>(ptr)->get_properties(props);
+			}
+			return props;
+		} catch (std::exception const& e) {
+			PLOG_ERROR("exception: %s", e.what());
+			throw e;
+		} catch (...) {
+			PLOG_ERROR("unknown exception");
+			throw;
+		}
+	};
+	this->info.oei.update = [](void* ptr, obs_data_t* settings) {
+		try {
+			return reinterpret_cast<generic*>(ptr)->update(settings);
+		} catch (std::exception const& e) {
+			PLOG_ERROR("exception: %s", e.what());
+			throw e;
+		} catch (...) {
+			PLOG_ERROR("unknown exception");
+			throw;
+		}
+	};
+	this->info.oei.get_sei_data = [](void* ptr, uint8_t** sei_data, size_t* size) {
+		try {
+			return reinterpret_cast<generic*>(ptr)->get_sei_data(sei_data, size);
+		} catch (std::exception const& e) {
+			PLOG_ERROR("exception: %s", e.what());
+			throw e;
+		} catch (...) {
+			PLOG_ERROR("unknown exception");
+			throw;
+		}
+	};
+	this->info.oei.get_extra_data = [](void* ptr, uint8_t** extra_data, size_t* size) {
+		try {
+			return reinterpret_cast<generic*>(ptr)->get_extra_data(extra_data, size);
+		} catch (std::exception const& e) {
+			PLOG_ERROR("exception: %s", e.what());
+			throw e;
+		} catch (...) {
+			PLOG_ERROR("unknown exception");
+			throw;
+		}
+	};
+
+	if (this->avcodec_ptr->type == AVMediaType::AVMEDIA_TYPE_VIDEO) {
+		this->info.oei.get_video_info = [](void* ptr, struct video_scale_info* info) {
+			try {
+				reinterpret_cast<generic*>(ptr)->get_video_info(info);
+			} catch (std::exception const& e) {
+				PLOG_ERROR("exception: %s", e.what());
+				throw e;
+			} catch (...) {
+				PLOG_ERROR("unknown exception");
+				throw;
+			}
+		};
+		this->info.oei.encode = [](void* ptr, struct encoder_frame* frame, struct encoder_packet* packet,
+		                           bool* received_packet) {
+			try {
+				return reinterpret_cast<generic*>(ptr)->video_encode(frame, packet, received_packet);
+			} catch (std::exception const& e) {
+				PLOG_ERROR("exception: %s", e.what());
+				throw e;
+			} catch (...) {
+				PLOG_ERROR("unknown exception");
+				throw;
+			}
+		};
+		this->info.oei.encode_texture = [](void* ptr, uint32_t handle, int64_t pts, uint64_t lock_key,
+		                                   uint64_t* next_key, struct encoder_packet* packet,
+		                                   bool* received_packet) {
+			try {
+				return reinterpret_cast<generic*>(ptr)->video_encode_texture(
+				    handle, pts, lock_key, next_key, packet, received_packet);
+			} catch (std::exception const& e) {
+				PLOG_ERROR("exception: %s", e.what());
+				throw e;
+			} catch (...) {
+				PLOG_ERROR("unknown exception");
+				throw;
+			}
+		};
+
+	} else if (this->avcodec_ptr->type == AVMediaType::AVMEDIA_TYPE_AUDIO) {
+		this->info.oei.get_audio_info = [](void* ptr, struct audio_convert_info* info) {
+			try {
+				reinterpret_cast<generic*>(ptr)->get_audio_info(info);
+			} catch (std::exception const& e) {
+				PLOG_ERROR("exception: %s", e.what());
+				throw e;
+			} catch (...) {
+				PLOG_ERROR("unknown exception");
+				throw;
+			}
+		};
+		this->info.oei.get_frame_size = [](void* ptr) {
+			try {
+				return reinterpret_cast<generic*>(ptr)->get_frame_size();
+			} catch (std::exception const& e) {
+				PLOG_ERROR("exception: %s", e.what());
+				throw e;
+			} catch (...) {
+				PLOG_ERROR("unknown exception");
+				throw;
+			}
+		};
+		this->info.oei.encode = [](void* ptr, struct encoder_frame* frame, struct encoder_packet* packet,
+		                           bool* received_packet) {
+			try {
+				return reinterpret_cast<generic*>(ptr)->audio_encode(frame, packet, received_packet);
+			} catch (std::exception const& e) {
+				PLOG_ERROR("exception: %s", e.what());
+				throw e;
+			} catch (...) {
+				PLOG_ERROR("unknown exception");
+				throw;
+			}
+		};
+	}
+
+	// Finally store ourself as type data.
+	this->info.oei.type_data = this;
+
+	obs_register_encoder(&this->info.oei);
+	PLOG_DEBUG("Registered encoder #%llX with name '%s' and long name '%s' and caps %llX", avcodec_ptr,
+	           avcodec_ptr->name, avcodec_ptr->long_name, avcodec_ptr->capabilities);
+}
+
+const char* encoder::generic_factory::get_name()
+{
+	return this->info.readable_name.c_str();
+}
+
+void encoder::generic_factory::get_defaults(obs_data_t* settings)
+{
+	{ // Handler
+		auto ptr = obsffmpeg::find_codec_handler(this->avcodec_ptr->name);
+		if (ptr) {
+			ptr->get_defaults(settings, this->avcodec_ptr, nullptr);
+		}
+	}
+
+	{ // Integrated Options
+		// FFmpeg
+		obs_data_set_default_string(settings, P_FFMPEG_CUSTOMSETTINGS, "");
+		obs_data_set_default_int(settings, P_FFMPEG_COLORFORMAT, static_cast<int64_t>(AV_PIX_FMT_NONE));
+		obs_data_set_default_int(settings, P_FFMPEG_THREADS, 0);
+		obs_data_set_default_int(settings, P_FFMPEG_STANDARDCOMPLIANCE, FF_COMPLIANCE_STRICT);
+	}
+}
+
+void encoder::generic_factory::get_properties(obs_properties_t* props)
+{
+	{ // Handler
+		auto ptr = obsffmpeg::find_codec_handler(this->avcodec_ptr->name);
+		if (ptr) {
+			ptr->get_properties(props, this->avcodec_ptr, nullptr);
+		}
+	}
+
+	{
+		obs_properties_t* grp = props;
+		if (!obsffmpeg::are_property_groups_broken()) {
+			auto prs = obs_properties_create();
+			obs_properties_add_group(props, P_FFMPEG, TRANSLATE(P_FFMPEG), OBS_GROUP_NORMAL, prs);
+		}
+
+		{
+			auto p =
+			    obs_properties_add_text(grp, P_FFMPEG_CUSTOMSETTINGS, TRANSLATE(P_FFMPEG_CUSTOMSETTINGS),
+			                            obs_text_type::OBS_TEXT_DEFAULT);
+			obs_property_set_long_description(p, TRANSLATE(DESC(P_FFMPEG_CUSTOMSETTINGS)));
+		}
+		if (this->avcodec_ptr->pix_fmts) {
+			auto p = obs_properties_add_list(grp, P_FFMPEG_COLORFORMAT, TRANSLATE(P_FFMPEG_COLORFORMAT),
+			                                 OBS_COMBO_TYPE_LIST, OBS_COMBO_FORMAT_INT);
+			obs_property_set_long_description(p, TRANSLATE(DESC(P_FFMPEG_COLORFORMAT)));
+			obs_property_list_add_int(p, TRANSLATE(P_AUTOMATIC), static_cast<int64_t>(AV_PIX_FMT_NONE));
+			for (auto ptr = this->avcodec_ptr->pix_fmts; *ptr != AV_PIX_FMT_NONE; ptr++) {
+				obs_property_list_add_int(p, ffmpeg::tools::get_pixel_format_name(*ptr),
+				                          static_cast<int64_t>(*ptr));
+			}
+		}
+		if (this->avcodec_ptr->capabilities & (AV_CODEC_CAP_FRAME_THREADS | AV_CODEC_CAP_SLICE_THREADS)) {
+			auto p = obs_properties_add_int_slider(grp, P_FFMPEG_THREADS, TRANSLATE(P_FFMPEG_THREADS), 0,
+			                                       std::thread::hardware_concurrency() * 2, 1);
+			obs_property_set_long_description(p, TRANSLATE(DESC(P_FFMPEG_THREADS)));
+		}
+		{
+			auto p = obs_properties_add_list(grp, P_FFMPEG_STANDARDCOMPLIANCE,
+			                                 TRANSLATE(P_FFMPEG_STANDARDCOMPLIANCE), OBS_COMBO_TYPE_LIST,
+			                                 OBS_COMBO_FORMAT_INT);
+			obs_property_set_long_description(p, TRANSLATE(DESC(P_FFMPEG_STANDARDCOMPLIANCE)));
+			obs_property_list_add_int(p, TRANSLATE(P_FFMPEG_STANDARDCOMPLIANCE ".VeryStrict"),
+			                          FF_COMPLIANCE_VERY_STRICT);
+			obs_property_list_add_int(p, TRANSLATE(P_FFMPEG_STANDARDCOMPLIANCE ".Strict"),
+			                          FF_COMPLIANCE_STRICT);
+			obs_property_list_add_int(p, TRANSLATE(P_FFMPEG_STANDARDCOMPLIANCE ".Normal"),
+			                          FF_COMPLIANCE_NORMAL);
+			obs_property_list_add_int(p, TRANSLATE(P_FFMPEG_STANDARDCOMPLIANCE ".Unofficial"),
+			                          FF_COMPLIANCE_UNOFFICIAL);
+			obs_property_list_add_int(p, TRANSLATE(P_FFMPEG_STANDARDCOMPLIANCE ".Experimental"),
+			                          FF_COMPLIANCE_EXPERIMENTAL);
+		}
+	};
+}
+
+AVCodec* encoder::generic_factory::get_avcodec()
+{
+	return this->avcodec_ptr;
+}
+
+encoder::generic::generic(obs_data_t* settings, obs_encoder_t* encoder)
+    : self(encoder), lag_in_frames(0), frame_count(0)
+{
+	this->factory = reinterpret_cast<generic_factory*>(obs_encoder_get_type_data(self));
+
+	// Verify that the codec actually still exists.
+	this->codec = avcodec_find_encoder_by_name(this->factory->get_avcodec()->name);
+	if (!this->codec) {
+		PLOG_ERROR("Failed to find encoder for codec '%s'.", this->factory->get_avcodec()->name);
+		throw std::runtime_error("failed to find codec");
+	}
+
+	// Initialize context.
+	this->context = avcodec_alloc_context3(this->codec);
+	if (!this->context) {
+		PLOG_ERROR("Failed to create context for encoder '%s'.", this->codec->name);
+		throw std::runtime_error("failed to create context");
+	}
+
+	// Settings
+	/// Rate Control
+	this->context->strict_std_compliance =
+	    static_cast<int>(obs_data_get_int(settings, P_FFMPEG_STANDARDCOMPLIANCE));
+	this->context->debug = 0;
+	/// Threading
+	if (this->codec->capabilities
+	    & (AV_CODEC_CAP_AUTO_THREADS | AV_CODEC_CAP_FRAME_THREADS | AV_CODEC_CAP_SLICE_THREADS)) {
+		if (this->codec->capabilities & AV_CODEC_CAP_FRAME_THREADS) {
+			this->context->thread_type |= FF_THREAD_FRAME;
+		}
+		if (this->codec->capabilities & AV_CODEC_CAP_SLICE_THREADS) {
+			this->context->thread_type |= FF_THREAD_SLICE;
+		}
+		int64_t threads = obs_data_get_int(settings, P_FFMPEG_THREADS);
+		if (threads > 0) {
+			this->context->thread_count = static_cast<int>(threads);
+			this->lag_in_frames         = this->context->thread_count;
+		} else {
+			this->context->thread_count = std::thread::hardware_concurrency();
+			this->lag_in_frames         = this->context->thread_count;
+		}
+	}
+
+	// Video and Audio exclusive setup
+	if (this->codec->type == AVMEDIA_TYPE_VIDEO) {
+		// FFmpeg Video Settings
+		auto encvideo = obs_encoder_video(this->self);
+		auto voi      = video_output_get_info(encvideo);
+
+		// Resolution
+		this->context->width  = voi->width;
+		this->context->height = voi->height;
+		this->swscale.set_source_size(this->context->width, this->context->height);
+		this->swscale.set_target_size(this->context->width, this->context->height);
+
+		// Color
+		this->context->colorspace  = ffmpeg::tools::obs_videocolorspace_to_avcolorspace(voi->colorspace);
+		this->context->color_range = ffmpeg::tools::obs_videorangetype_to_avcolorrange(voi->range);
+		this->context->field_order = AV_FIELD_PROGRESSIVE;
+		this->swscale.set_source_color(this->context->color_range, this->context->colorspace);
+		this->swscale.set_target_color(this->context->color_range, this->context->colorspace);
+
+		// Pixel Format
+		{
+			// Due to unsupported color formats and ffmpeg not automatically converting formats from A to B,
+			// we have to detect the closest format that we can still use and initialize our swscale instance
+			// these formats. This has a massive cost attached unfortunately.
+
+			AVPixelFormat source = ffmpeg::tools::obs_videoformat_to_avpixelformat(voi->format);
+			AVPixelFormat target = AV_PIX_FMT_NONE;
+
+			int loss = 0;
+			target   = avcodec_find_best_pix_fmt_of_list(this->codec->pix_fmts, source, false, &loss);
+
+			this->context->pix_fmt = target;
+			this->swscale.set_source_format(source);
+			this->swscale.set_target_format(this->context->pix_fmt);
+
+			PLOG_INFO("Automatically detected target format '%s' for source format '%s'.",
+			          ffmpeg::tools::get_pixel_format_name(target),
+			          ffmpeg::tools::get_pixel_format_name(source));
+		}
+		AVPixelFormat color_format_override =
+		    static_cast<AVPixelFormat>(obs_data_get_int(settings, P_FFMPEG_COLORFORMAT));
+		if (color_format_override != AV_PIX_FMT_NONE) {
+			// User specified override for color format.
+			this->context->pix_fmt = color_format_override;
+			this->swscale.set_target_format(this->context->pix_fmt);
+			PLOG_INFO("User specified target format override '%s'.",
+			          ffmpeg::tools::get_pixel_format_name(this->context->pix_fmt));
+		}
+
+		// Framerate
+		this->context->time_base.num   = voi->fps_den;
+		this->context->time_base.den   = voi->fps_num;
+		this->context->ticks_per_frame = 1;
+	} else if (this->codec->type == AVMEDIA_TYPE_AUDIO) {
+	}
+
+	// Update settings
+	this->update(settings);
+
+	// Initialize
+	int res = avcodec_open2(this->context, this->codec, NULL);
+	if (res < 0) {
+		PLOG_ERROR("Failed to initialize encoder '%s' due to error code %lld: %s", this->codec->name, res,
+		           ffmpeg::tools::get_error_description(res));
+		throw std::runtime_error(ffmpeg::tools::get_error_description(res));
+	}
+
+	// Video/Audio exclusive setup part 2.
+	if (this->codec->type == AVMEDIA_TYPE_VIDEO) {
+		// Create Scaler
+		if (!swscale.initialize(SWS_FAST_BILINEAR)) {
+			PLOG_ERROR(
+			    " Failed to initialize Software Scaler for pixel format '%s' with color space '%s' and "
+			    "range '%s'.",
+			    ffmpeg::tools::get_pixel_format_name(this->context->pix_fmt),
+			    ffmpeg::tools::get_color_space_name(this->context->colorspace),
+			    this->swscale.is_source_full_range() ? "Full" : "Partial");
+			throw std::runtime_error("failed to initialize swscaler.");
+		}
+
+		// Create Frame queue
+		this->frame_queue.set_pixel_format(this->context->pix_fmt);
+		this->frame_queue.set_resolution(this->context->width, this->context->height);
+		this->frame_queue.precache(std::thread::hardware_concurrency() / 4);
+	} else if (this->codec->type == AVMEDIA_TYPE_AUDIO) {
+	}
+
+	// Create Packet
+	this->current_packet = av_packet_alloc();
+	if (!this->current_packet) {
+		PLOG_ERROR("Failed to allocate packet storage.");
+		throw std::runtime_error("Failed to allocate packet storage.");
+	}
+}
+
+encoder::generic::~generic()
+{
+	this->frame_queue.clear();
+	this->frame_queue_used.clear();
+	this->swscale.finalize();
+
+	if (this->context) {
+		avcodec_close(this->context);
+		avcodec_free_context(&this->context);
+	}
+}
+
+void encoder::generic::get_properties(obs_properties_t* props)
+{
+	{ // Handler
+		auto ptr = obsffmpeg::find_codec_handler(this->codec->name);
+		if (ptr) {
+			ptr->get_properties(props, this->codec, this->context);
+		}
+	}
+
+	obs_property_set_enabled(obs_properties_get(props, P_FFMPEG_COLORFORMAT), false);
+	obs_property_set_enabled(obs_properties_get(props, P_FFMPEG_THREADS), false);
+	obs_property_set_enabled(obs_properties_get(props, P_FFMPEG_STANDARDCOMPLIANCE), false);
+}
+
+bool encoder::generic::update(obs_data_t* settings)
+{
+	{ // Handler
+		auto ptr = obsffmpeg::find_codec_handler(this->codec->name);
+		if (ptr) {
+			ptr->update(settings, this->codec, this->context);
+		}
+	}
+
+	{ // FFmpeg
+		// Apply custom options.
+		av_opt_set_from_string(this->context->priv_data, obs_data_get_string(settings, P_FFMPEG_CUSTOMSETTINGS),
+		                       nullptr, "=", ";");
+	}
+	return false;
+}
+
+void encoder::generic::get_audio_info(audio_convert_info*) {}
+
+size_t encoder::generic::get_frame_size()
+{
+	return size_t();
+}
+
+bool encoder::generic::audio_encode(encoder_frame*, encoder_packet*, bool*)
+{
+	return false;
+}
+
+void encoder::generic::get_video_info(video_scale_info*) {}
+
+bool encoder::generic::get_sei_data(uint8_t**, size_t*)
+{
+	return false;
+}
+
+bool encoder::generic::get_extra_data(uint8_t** extra_data, size_t* size)
+{
+	if (!this->context->extradata) {
+		return false;
+	}
+	*extra_data = this->context->extradata;
+	*size       = this->context->extradata_size;
+	return true;
+}
+
+bool encoder::generic::video_encode(encoder_frame* frame, encoder_packet* packet, bool* received_packet)
+{
+	// Convert frame.
+	std::shared_ptr<AVFrame> vframe = frame_queue.pop(); // Retrieve an empty frame.
+	{
+		ScopeProfiler profile("convert");
+
+		vframe->color_range = this->context->color_range;
+		vframe->colorspace  = this->context->colorspace;
+
+		int res =
+		    swscale.convert(reinterpret_cast<uint8_t**>(frame->data), reinterpret_cast<int*>(frame->linesize),
+		                    0, this->context->height, vframe->data, vframe->linesize);
+		if (res <= 0) {
+			PLOG_ERROR("Failed to convert frame: %s (%ld).", ffmpeg::tools::get_error_description(res),
+			           res);
+			return false;
+		}
+	}
+
+	// Send and receive frames.
+	{
+		ScopeProfiler profile("loop");
+		bool          sent_frame  = false;
+		bool          recv_packet = false;
+		bool          should_lag  = (lag_in_frames - frame_count) <= 0;
+
+		auto loop_begin = std::chrono::high_resolution_clock::now();
+		auto loop_end   = loop_begin + std::chrono::milliseconds(50);
+
+		while ((!sent_frame || (should_lag && !recv_packet))
+		       && !(std::chrono::high_resolution_clock::now() > loop_end)) {
+			bool eagain_is_stupid = false;
+
+			if (!sent_frame) {
+				ScopeProfiler profile_inner("send");
+
+				vframe->pts = frame->pts;
+
+				int res = send_frame(vframe);
+				switch (res) {
+				case 0:
+					sent_frame = true;
+					frame_count++;
+					break;
+				case AVERROR(EAGAIN):
+					// This means we should call receive_packet again, but what do we do with that data?
+					// Why can't we queue on both? Do I really have to implement threading for this stuff?
+					if (*received_packet == true) {
+						PLOG_WARNING(
+						    "Skipped frame due to EAGAIN when a packet was already returned.");
+						sent_frame = true;
+						frame_count++;
+					}
+					eagain_is_stupid = true;
+					break;
+				case AVERROR(EOF):
+					PLOG_ERROR("Skipped frame due to end of stream.");
+					sent_frame = true;
+					break;
+				default:
+					PLOG_ERROR("Failed to encode frame: %s (%ld).",
+					           ffmpeg::tools::get_error_description(res), res);
+					return false;
+				}
+			}
+
+			if (!recv_packet) {
+				ScopeProfiler profile_inner("recieve");
+
+				int res = receive_packet(received_packet, packet);
+				switch (res) {
+				case 0:
+					recv_packet = true;
+					break;
+				case AVERROR(EOF):
+					PLOG_ERROR("Received end of file.");
+					recv_packet = true;
+					break;
+				case AVERROR(EAGAIN):
+					if (sent_frame) {
+						recv_packet = true;
+					}
+					if (eagain_is_stupid) {
+						PLOG_ERROR("Both send and recieve returned EAGAIN, encoder is broken.");
+						return false;
+					}
+					break;
+				default:
+					PLOG_ERROR("Failed to receive packet: %s (%ld).",
+					           ffmpeg::tools::get_error_description(res), res);
+					return false;
+				}
+			}
+
+			if (!sent_frame || !recv_packet) {
+				std::this_thread::sleep_for(std::chrono::milliseconds(1));
+			}
+		}
+	}
+
+	return true;
+}
+
+bool encoder::generic::video_encode_texture(uint32_t, int64_t, uint64_t, uint64_t*, encoder_packet*, bool*)
+{
+	return false;
+}
+
+int encoder::generic::receive_packet(bool* received_packet, struct encoder_packet* packet)
+{
+	int res = avcodec_receive_packet(this->context, this->current_packet);
+	if (res == 0) {
+		packet->type          = OBS_ENCODER_VIDEO;
+		packet->pts           = this->current_packet->pts;
+		packet->dts           = this->current_packet->dts;
+		packet->data          = this->current_packet->data;
+		packet->size          = this->current_packet->size;
+		packet->keyframe      = !!(this->current_packet->flags & AV_PKT_FLAG_KEY);
+		packet->drop_priority = 0;
+		*received_packet      = true;
+
+		{
+			std::shared_ptr<AVFrame> uframe = frame_queue_used.pop_only();
+			frame_queue.push(uframe);
+		}
+	}
+	return res;
+}
+
+int encoder::generic::send_frame(std::shared_ptr<AVFrame> frame)
+{
+	int res = avcodec_send_frame(this->context, frame.get());
+	switch (res) {
+	case 0:
+		frame_count++;
+	case AVERROR(EAGAIN):
+	case AVERROR(EOF):
+		break;
+	}
+	return res;
+}

source/encoders/generic.hpp

@@ -0,0 +1,104 @@
+// FFMPEG Video Encoder Integration for OBS Studio
+// Copyright (C) 2018 - 2019 Michael Fabian Dirks
+//
+// This program is free software; you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation; either version 2 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program; if not, write to the Free Software
+// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+
+#pragma once
+
+#include <condition_variable>
+#include <encoder.hpp>
+#include <mutex>
+#include <thread>
+#include "ffmpeg/avframe-queue.hpp"
+#include "ffmpeg/swscale.hpp"
+
+namespace encoder {
+	class generic_factory {
+		struct info {
+			std::string      uid;
+			std::string      codec;
+			std::string      readable_name;
+			obs_encoder_info oei;
+		} info;
+		AVCodec* avcodec_ptr;
+
+		public:
+		generic_factory(AVCodec* codec);
+		virtual ~generic_factory();
+
+		void register_encoder();
+
+		const char* get_name();
+
+		void get_defaults(obs_data_t* settings);
+
+		void get_properties(obs_properties_t* props);
+
+		AVCodec* get_avcodec();
+
+		public:
+		static bool modified_ratecontrol_properties(void* priv, obs_properties_t* props, obs_property_t* prop,
+		                                            obs_data_t* settings);
+	};
+
+	class generic {
+		obs_encoder_t*   self;
+		generic_factory* factory;
+
+		AVCodec*        codec;
+		AVCodecContext* context;
+
+		ffmpeg::avframe_queue frame_queue;
+		ffmpeg::avframe_queue frame_queue_used;
+		ffmpeg::swscale       swscale;
+		AVPacket*             current_packet = nullptr;
+
+		int64_t lag_in_frames;
+		int64_t frame_count;
+
+		public:
+		generic(obs_data_t* settings, obs_encoder_t* encoder);
+		virtual ~generic();
+
+		public: // OBS API
+		// Shared
+		void get_properties(obs_properties_t* props);
+
+		bool update(obs_data_t* settings);
+
+		// Audio only
+		void get_audio_info(struct audio_convert_info* info);
+
+		size_t get_frame_size();
+
+		bool audio_encode(struct encoder_frame* frame, struct encoder_packet* packet, bool* received_packet);
+
+		// Video only
+		void get_video_info(struct video_scale_info* info);
+
+		bool get_sei_data(uint8_t** sei_data, size_t* size);
+
+		bool get_extra_data(uint8_t** extra_data, size_t* size);
+
+		bool video_encode(struct encoder_frame* frame, struct encoder_packet* packet, bool* received_packet);
+
+		bool video_encode_texture(uint32_t handle, int64_t pts, uint64_t lock_key, uint64_t* next_key,
+		                          struct encoder_packet* packet, bool* received_packet);
+
+		int receive_packet(bool* received_packet, struct encoder_packet* packet);
+
+		int send_frame(std::shared_ptr<AVFrame> frame);
+	};
+} // namespace encoder

source/encoders/prores_aw.cpp

@@ -33,7 +33,7 @@ extern "C" {
 #include <util/profiler.hpp>
 
 #define T_PROFILE "ProRes.Profile"
-#define T_PROFILE_(x) "ProRes.Profile." vstr(x)
+#define T_PROFILE_(x) "ProRes.Profile." D_VSTR(x)
 #define T_CUSTOM "Custom"
 
 #define LOG_PREFIX "[prores_aw] "
@@ -241,9 +241,9 @@ obsffmpeg::encoder::prores_aw::~prores_aw()
 	}
 }
 
-void obsffmpeg::encoder::prores_aw::get_properties(obs_properties_t* props) {}
+void obsffmpeg::encoder::prores_aw::get_properties(obs_properties_t*) {}
 
-bool obsffmpeg::encoder::prores_aw::update(obs_data_t* settings)
+bool obsffmpeg::encoder::prores_aw::update(obs_data_t*)
 {
 	return false;
 }
@@ -258,12 +258,12 @@ bool obsffmpeg::encoder::prores_aw::get_extra_data(uint8_t** extra_data, size_t*
 	return true;
 }
 
-bool obsffmpeg::encoder::prores_aw::get_sei_data(uint8_t** sei_data, size_t* size)
+bool obsffmpeg::encoder::prores_aw::get_sei_data(uint8_t**, size_t*)
 {
 	return false;
 }
 
-void obsffmpeg::encoder::prores_aw::get_video_info(video_scale_info* info)
+void obsffmpeg::encoder::prores_aw::get_video_info(video_scale_info*)
 {
 	return;
 }
@@ -274,7 +274,7 @@ bool obsffmpeg::encoder::prores_aw::encode(encoder_frame* frame, encoder_packet*
 
 	{
 		ScopeProfiler            sp_frame("frame");
-		AVFrame*      vframe = frame_queue.pop();
+		std::shared_ptr<AVFrame> vframe = frame_queue.pop();
 		vframe->pts                     = frame->pts;
 
 		vframe->color_range = this->avcontext->color_range;
@@ -294,7 +294,7 @@ bool obsffmpeg::encoder::prores_aw::encode(encoder_frame* frame, encoder_packet*
 
 		{
 			ScopeProfiler profile("send");
-			res = avcodec_send_frame(this->avcontext, vframe);
+			res = avcodec_send_frame(this->avcontext, vframe.get());
 			if (res < 0) {
 				PLOG_ERROR(LOG_PREFIX "Failed to encode frame: %s (%ld).",
 				           ffmpeg::tools::get_error_description(res), res);
@@ -320,12 +320,10 @@ bool obsffmpeg::encoder::prores_aw::encode(encoder_frame* frame, encoder_packet*
 				return false;
 			}
 		} else {
-			AVFrame* uframe = frame_queue_used.pop_only();
+			std::shared_ptr<AVFrame> uframe = frame_queue_used.pop_only();
 			if (uframe) {
 				if (frame_queue.empty()) {
 					frame_queue.push(uframe);
-				} else {
-					av_frame_free(&uframe);
 				}
 			}
 			packet->type          = OBS_ENCODER_VIDEO;

source/encoders/prores_aw.hpp

@@ -15,13 +15,11 @@
 // along with this program; if not, write to the Free Software
 // Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
 
-#ifndef OBS_FFMPEG_ENCODER_PRORES_AW
-#define OBS_FFMPEG_ENCODER_PRORES_AW
 #pragma once
 
 #include <encoder.hpp>
-#include "ffmpeg/avframe-queue.hpp"
 #include <vector>
+#include "ffmpeg/avframe-queue.hpp"
 
 extern "C" {
 #include <libavcodec/avcodec.h>
@@ -36,7 +34,8 @@ namespace obsffmpeg {
 				Light       = 1 /*FF_PROFILE_PRORES_LT*/,
 				Standard    = 2 /*FF_PROFILE_PRORES_STANDARD*/,
 				HighQuality = 3 /*FF_PROFILE_PRORES_HQ*/,
-				FourFourFourFour = 4 /*FF_PROFILE_PRORES_4444*/ // Automatically set if I444 or RGB input.
+				FourFourFourFour =
+				    4 /*FF_PROFILE_PRORES_4444*/ // Automatically set if I444 or RGB input.
 			};
 
 			private:
@@ -45,8 +44,6 @@ namespace obsffmpeg {
 			ffmpeg::avframe_queue frame_queue_used;
 			AVPacket*             current_packet = nullptr;
 
-			
-
 			public:
 			prores_aw(obs_data_t* settings, obs_encoder_t* encoder);
 
@@ -76,5 +73,3 @@ namespace obsffmpeg {
 		};
 	} // namespace encoder
 } // namespace obsffmpeg
-
-#endif OBS_FFMPEG_ENCODER_PRORES_AW

source/ffmpeg/avframe-queue.cpp

@@ -18,13 +18,15 @@
 #include "avframe-queue.hpp"
 #include "tools.hpp"
 
-AVFrame* ffmpeg::avframe_queue::create_frame()
+std::shared_ptr<AVFrame> ffmpeg::avframe_queue::create_frame()
 {
-	AVFrame* frame = av_frame_alloc();
+	std::shared_ptr<AVFrame> frame =
+	    std::shared_ptr<AVFrame>(av_frame_alloc(), [](AVFrame* frame) { av_frame_free(&frame); });
 	frame->width  = this->resolution.first;
 	frame->height = this->resolution.second;
 	frame->format = this->format;
-	int res        = av_frame_get_buffer(frame, 0);
+
+	int res = av_frame_get_buffer(frame.get(), 32);
 	if (res < 0) {
 		throw std::exception(ffmpeg::tools::get_error_description(res));
 	}
@@ -32,14 +34,6 @@ AVFrame* ffmpeg::avframe_queue::create_frame()
 	return frame;
 }
 
-void ffmpeg::avframe_queue::destroy_frame(AVFrame* frame)
-{
-	if (frame == nullptr)
-		return;
-
-	av_frame_free(&frame);
-}
-
 ffmpeg::avframe_queue::avframe_queue() {}
 
 ffmpeg::avframe_queue::~avframe_queue()
@@ -89,23 +83,19 @@ void ffmpeg::avframe_queue::precache(size_t count)
 void ffmpeg::avframe_queue::clear()
 {
 	std::unique_lock<std::mutex> ulock(this->lock);
-	for (AVFrame* frame : frames) {
-		destroy_frame(frame);
-	}
 	frames.clear();
 }
 
-void ffmpeg::avframe_queue::push(AVFrame* frame)
+void ffmpeg::avframe_queue::push(std::shared_ptr<AVFrame> frame)
 {
 	std::unique_lock<std::mutex> ulock(this->lock);
 	frames.push_back(frame);
 }
 
-AVFrame* ffmpeg::avframe_queue::pop()
+std::shared_ptr<AVFrame> ffmpeg::avframe_queue::pop()
 {
 	std::unique_lock<std::mutex> ulock(this->lock);
-
-	AVFrame* ret = nullptr;
+	std::shared_ptr<AVFrame>     ret;
 	while (ret == nullptr) {
 		if (frames.size() == 0) {
 			ret = create_frame();
@@ -115,9 +105,9 @@ AVFrame* ffmpeg::avframe_queue::pop()
 				ret = create_frame();
 			} else {
 				frames.pop_front();
-				if ((ret->width != this->resolution.first) || (ret->height != this->resolution.second)
+				if ((static_cast<uint32_t>(ret->width) != this->resolution.first)
+				    || (static_cast<uint32_t>(ret->height) != this->resolution.second)
 				    || (ret->format != this->format)) {
-					destroy_frame(ret);
 					ret = nullptr;
 				}
 			}
@@ -126,13 +116,13 @@ AVFrame* ffmpeg::avframe_queue::pop()
 	return ret;
 }
 
-AVFrame* ffmpeg::avframe_queue::pop_only()
+std::shared_ptr<AVFrame> ffmpeg::avframe_queue::pop_only()
 {
 	std::unique_lock<std::mutex> ulock(this->lock);
 	if (frames.size() == 0) {
 		return nullptr;
 	}
-	AVFrame* ret = frames.front();
+	std::shared_ptr<AVFrame> ret = frames.front();
 	if (ret == nullptr) {
 		return nullptr;
 	}

source/ffmpeg/avframe-queue.hpp

@@ -15,27 +15,26 @@
 // along with this program; if not, write to the Free Software
 // Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
 
-#ifndef OBS_FFMPEG_FFMPEG_AVFRAME_QUEUE
-#define OBS_FFMPEG_FFMPEG_AVFRAME_QUEUE
 #pragma once
-
-#include <mutex>
 #include <deque>
+#include <mutex>
 
 extern "C" {
+#pragma warning(push)
+#pragma warning(disable : 4244)
 #include <libavutil/frame.h>
+#pragma warning(pop)
 }
 
 namespace ffmpeg {
 	class avframe_queue {
-		std::deque<AVFrame*> frames;
+		std::deque<std::shared_ptr<AVFrame>> frames;
 		std::mutex                           lock;
 
 		std::pair<uint32_t, uint32_t> resolution;
 		AVPixelFormat                 format = AV_PIX_FMT_NONE;
 
-		AVFrame* create_frame();
-		void     destroy_frame(AVFrame* frame);
+		std::shared_ptr<AVFrame> create_frame();
 
 		public:
 		avframe_queue();
@@ -53,18 +52,14 @@ namespace ffmpeg {
 
 		void clear();
 
-		void push(AVFrame* frame);
+		void push(std::shared_ptr<AVFrame> frame);
 
-		AVFrame* pop();
+		std::shared_ptr<AVFrame> pop();
 
-		AVFrame* pop_only();
+		std::shared_ptr<AVFrame> pop_only();
 
 		bool empty();
 
 		size_t size();
-
-
 	};
 } // namespace ffmpeg
-
-#endif OBS_FFMPEG_FFMPEG_AVFRAME_QUEUE

source/ffmpeg/swscale.cpp

@@ -94,7 +94,11 @@ void ffmpeg::swscale::set_target_size(uint32_t width, uint32_t height)
 	target_size.second = height;
 }
 
-void ffmpeg::swscale::get_target_size(uint32_t& width, uint32_t& height) {}
+void ffmpeg::swscale::get_target_size(uint32_t& width, uint32_t& height)
+{
+	width  = target_size.first;
+	height = target_size.second;
+}
 
 std::pair<uint32_t, uint32_t> ffmpeg::swscale::get_target_size()
 {

source/ffmpeg/swscale.hpp

@@ -23,8 +23,11 @@
 #include <utility>
 
 extern "C" {
+#pragma warning(push)
+#pragma warning(disable : 4244)
 #include <libavutil/pixfmt.h>
 #include <libswscale/swscale.h>
+#pragma warning(pop)
 }
 
 namespace ffmpeg {

source/ffmpeg/tools.cpp

@@ -16,11 +16,63 @@
 // Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
 
 #include "tools.hpp"
+#include <sstream>
 #include <stdexcept>
 
 extern "C" {
+#pragma warning(push)
+#pragma warning(disable : 4244)
+#include <libavcodec/avcodec.h>
 #include <libavutil/error.h>
 #include <libavutil/pixdesc.h>
+#pragma warning(pop)
+}
+
+std::string ffmpeg::tools::translate_encoder_capabilities(int capabilities)
+{
+	// Sorted by relative importance.
+	std::pair<int, std::string> caps[] = {
+	    {AV_CODEC_CAP_EXPERIMENTAL, "Experimental"},
+
+	    // Quality
+	    {AV_CODEC_CAP_LOSSLESS, "Lossless"},
+	    //{AV_CODEC_CAP_INTRA_ONLY, "I-Frames only"},
+
+	    // Threading
+	    //{AV_CODEC_CAP_FRAME_THREADS, "Frame-Threading"},
+	    //{AV_CODEC_CAP_SLICE_THREADS, "Slice-Threading"},
+	    //{AV_CODEC_CAP_AUTO_THREADS, "Automatic-Threading"},
+
+	    // Features
+	    {AV_CODEC_CAP_PARAM_CHANGE, "Dynamic Parameter Change"},
+	    {AV_CODEC_CAP_SUBFRAMES, "Sub-Frames"},
+	    {AV_CODEC_CAP_VARIABLE_FRAME_SIZE, "Variable Frame Size"},
+	    {AV_CODEC_CAP_SMALL_LAST_FRAME, "Small Final Frame"},
+	    //{AV_CODEC_CAP_DR1, "Uses get_buffer"},
+	    //{AV_CODEC_CAP_DELAY, "Requires Flush"},
+
+	    // Other
+	    {AV_CODEC_CAP_TRUNCATED, "Truncated"},
+	    {AV_CODEC_CAP_CHANNEL_CONF, "AV_CODEC_CAP_CHANNEL_CONF"},
+	    {AV_CODEC_CAP_DRAW_HORIZ_BAND, "AV_CODEC_CAP_DRAW_HORIZ_BAND"},
+	    {AV_CODEC_CAP_HWACCEL_VDPAU, "AV_CODEC_CAP_HWACCEL_VDPAU"},
+	    {AV_CODEC_CAP_AVOID_PROBING, "AV_CODEC_CAP_AVOID_PROBING"},
+	};
+
+	std::stringstream sstr;
+	for (auto kv : caps) {
+		if (capabilities & kv.first) {
+			capabilities &= ~kv.first;
+			sstr << kv.second;
+			if (capabilities != 0) {
+				sstr << ", ";
+			} else {
+				break;
+			}
+		}
+	}
+
+	return sstr.str();
 }
 
 const char* ffmpeg::tools::get_pixel_format_name(AVPixelFormat v)
@@ -67,10 +119,47 @@ const char* ffmpeg::tools::get_error_description(int error)
 	switch (error) {
 	case AVERROR(EPERM):
 		return "Permission Denied";
+		//	case AVERROR(ENOENT):
+		//	case AVERROR(ESRCH):
+		//	case AVERROR(EINTR):
+		//	case AVERROR(EIO):
+		//	case AVERROR(ENXIO):
+		//	case AVERROR(E2BIG):
+		//	case AVERROR(ENOEXEC):
+		//	case AVERROR(EBADF):
+		//	case AVERROR(ECHILD):
+		//	case AVERROR(EAGAIN):
 	case AVERROR(ENOMEM):
 		return "Out Of Memory";
+		//	case AVERROR(EACCES):
+		//	case AVERROR(EFAULT):
+		//	case AVERROR(EBUSY):
+		//	case AVERROR(EEXIST):
+		//	case AVERROR(EXDEV):
+		//	case AVERROR(ENODEV):
+		//	case AVERROR(ENOTDIR):
+		//	case AVERROR(EISDIR):
+		//	case AVERROR(ENFILE):
+		//	case AVERROR(EMFILE):
+		//	case AVERROR(ENOTTY):
+		//	case AVERROR(EFBIG):
+		//	case AVERROR(ENOSPC):
+		//	case AVERROR(ESPIPE):
+		//	case AVERROR(EROFS):
+		//	case AVERROR(EMLINK):
+		//	case AVERROR(EPIPE):
+		//	case AVERROR(EDOM):
+		//	case AVERROR(EDEADLK):
+		//	case AVERROR(ENAMETOOLONG):
+		//	case AVERROR(ENOLCK):
+		//	case AVERROR(ENOSYS):
+		//	case AVERROR(ENOTEMPTY):
 	case AVERROR(EINVAL):
-		return "Invalid Value for Parameter";
+		return "Invalid Value(s)";
+	case AVERROR(ERANGE):
+		return "Out of Range";
+		//	case AVERROR(EILSEQ):
+		//	case AVERROR(STRUNCATE):
 	}
 	return "Not Translated Yet";
 }

source/ffmpeg/tools.hpp

@@ -20,6 +20,7 @@
 #pragma once
 
 #include <obs.h>
+#include <string>
 
 extern "C" {
 #include <libavutil/pixfmt.h>
@@ -27,6 +28,8 @@ extern "C" {
 
 namespace ffmpeg {
 	namespace tools {
+		std::string translate_encoder_capabilities(int capabilities);
+
 		const char* get_pixel_format_name(AVPixelFormat v);
 
 		const char* get_color_space_name(AVColorSpace v);
@@ -38,7 +41,7 @@ namespace ffmpeg {
 		AVColorSpace obs_videocolorspace_to_avcolorspace(video_colorspace v);
 
 		AVColorRange obs_videorangetype_to_avcolorrange(video_range_type v);
-	}
+	} // namespace tools
 } // namespace ffmpeg
 
 #endif OBS_FFMPEG_FFMPEG_UTILITY

source/plugin.cpp

@@ -16,40 +16,95 @@
 // Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
 
 #include "plugin.hpp"
-#include <obs-module.h>
-#include <obs.h>
+#include <memory>
+#include "encoders/generic.hpp"
+#include "encoders/prores_aw.hpp"
+#include "ui/debug_handler.hpp"
+#include "ui/handler.hpp"
 #include "utility.hpp"
 
-#include "encoders/prores_aw.hpp"
-
 extern "C" {
+#include <obs-module.h>
+#include <obs.h>
 #pragma warning(push)
 #pragma warning(disable : 4244)
 #include <libavcodec/avcodec.h>
 #pragma warning(pop)
 }
 
-MODULE_EXPORT bool obs_module_load(void)
+// Initializers and finalizers.
+std::list<std::function<void()>> obsffmpeg::initializers;
+
+std::list<std::function<void()>> obsffmpeg::finalizers;
+
+// Codec to Handler mapping.
+static std::map<std::string, std::shared_ptr<obsffmpeg::ui::handler>> codec_to_handler_map;
+static std::shared_ptr<obsffmpeg::ui::handler> debug_handler = std::make_shared<obsffmpeg::ui::debug_handler>();
+
+void obsffmpeg::register_codec_handler(std::string codec, std::shared_ptr<obsffmpeg::ui::handler> handler)
 {
-	try {
+	codec_to_handler_map.emplace(codec, handler);
+}
+
+std::shared_ptr<obsffmpeg::ui::handler> obsffmpeg::find_codec_handler(std::string codec)
+{
+	auto found = codec_to_handler_map.find(codec);
+	if (found == codec_to_handler_map.end())
+		return debug_handler;
+	return found->second;
+}
+
+bool obsffmpeg::has_codec_handler(std::string codec)
+{
+	auto found = codec_to_handler_map.find(codec);
+	return (found != codec_to_handler_map.end());
+}
+
+static std::map<AVCodec*, std::shared_ptr<encoder::generic_factory>> generic_factories;
+
+MODULE_EXPORT bool obs_module_load(void)
+try {
+	// Initialize avcodec.
 	avcodec_register_all();
+
+	// Run all initializers.
+	for (auto func : obsffmpeg::initializers) {
+		func();
+	}
+
+	// Register all codecs.
+	AVCodec* cdc = nullptr;
+	while ((cdc = av_codec_next(cdc)) != nullptr) {
+		if (!av_codec_is_encoder(cdc))
+			continue;
+
+		if ((cdc->type == AVMediaType::AVMEDIA_TYPE_AUDIO) || (cdc->type == AVMediaType::AVMEDIA_TYPE_VIDEO)) {
+			auto ptr = std::make_shared<encoder::generic_factory>(cdc);
+			ptr->register_encoder();
+			generic_factories.emplace(cdc, ptr);
+		}
+	}
+
 	obsffmpeg::encoder::prores_aw::initialize();
 	return true;
-	} catch (std::exception ex) {
+} catch (std::exception ex) {
 	PLOG_ERROR("Exception during initalization: %s.", ex.what());
-	} catch (...) {
+	return false;
+} catch (...) {
 	PLOG_ERROR("Unrecognized exception during initalization.");
-	}
 	return false;
 }
 
 MODULE_EXPORT void obs_module_unload(void)
-{
-	try {
+try {
 	obsffmpeg::encoder::prores_aw::finalize();
-	} catch (std::exception ex) {
-		PLOG_ERROR("Exception during finalizing: %s.", ex.what());
-	} catch (...) {
-		PLOG_ERROR("Unrecognized exception during finalizing.");
+
+	// Run all finalizers.
+	for (auto func : obsffmpeg::finalizers) {
+		func();
 	}
+} catch (std::exception ex) {
+	PLOG_ERROR("Exception during finalizing: %s.", ex.what());
+} catch (...) {
+	PLOG_ERROR("Unrecognized exception during finalizing.");
 }

source/plugin.hpp

@@ -1,5 +1,5 @@
 // FFMPEG Video Encoder Integration for OBS Studio
-// Copyright (C) 2018 - 2018 Michael Fabian Dirks
+// Copyright (C) 2018 - 2019 Michael Fabian Dirks
 //
 // This program is free software; you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
@@ -15,16 +15,25 @@
 // along with this program; if not, write to the Free Software
 // Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
 
-#ifndef OBS_FFMPEG_PLUGIN_HPP
-#define OBS_FFMPEG_PLUGIN_HPP
 #pragma once
-
 #include <functional>
 #include <list>
+#include <memory>
+#include <obs-module.h>
+#include "ui/handler.hpp"
 
 namespace obsffmpeg {
+	extern std::list<std::function<void()>> initializers;
 
+	extern std::list<std::function<void()>> finalizers;
+
+	void register_codec_handler(std::string codec, std::shared_ptr<obsffmpeg::ui::handler> handler);
+
+	std::shared_ptr<obsffmpeg::ui::handler> find_codec_handler(std::string codec);
+
+	bool has_codec_handler(std::string codec);
 
 } // namespace obsffmpeg
 
-#endif OBS_FFMPEG_PLUGIN_HPP
+MODULE_EXPORT bool obs_module_load(void);
+MODULE_EXPORT void obs_module_unload(void);

source/strings.hpp

@@ -0,0 +1,49 @@
+// FFMPEG Video Encoder Integration for OBS Studio
+// Copyright (C) 2018 - 2019 Michael Fabian Dirks
+//
+// This program is free software; you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation; either version 2 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program; if not, write to the Free Software
+// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+
+#pragma once
+#include "utility.hpp"
+
+#define G_STATE_DEFAULT "State.Default"
+#define G_STATE_DISABLED "State.Disabled"
+#define G_STATE_ENABLED "State.Enabled"
+#define G_STATE_AUTOMATIC "State.Automatic"
+#define G_STATE_MANUAL "State.Manual"
+
+#define G_RATECONTROL "RateControl"
+#define G_RATECONTROL_MODE "RateControl.Mode"
+#define G_RATECONTROL_MODE_(x) "RateControl.Mode." D_VSTR(x)
+#define G_RATECONTROL_BITRATE_TARGET "RateControl.Bitrate.Target"
+#define G_RATECONTROL_BITRATE_MINIMUM "RateControl.Bitrate.Minimum"
+#define G_RATECONTROL_BITRATE_MAXIMUM "RateControl.Bitrate.Maximum"
+#define G_RATECONTROL_BUFFERSIZE "RateControl.BufferSize"
+#define G_RATECONTROL_QUALITY_TARGET "RateControl.Quality.Target"
+#define G_RATECONTROL_QUALITY_MINIMUM "RateControl.Quality.Minimum"
+#define G_RATECONTROL_QUALITY_MAXIMUM "RateControl.Quality.Maximum"
+#define G_RATECONTROL_QP_I "RateControl.QP.I"
+#define G_RATECONTROL_QP_P "RateControl.QP.P"
+#define G_RATECONTROL_QP_B "RateControl.QP.B"
+#define G_RATECONTROL_QP_I_INITIAL "RateControl.QP.I.Initial"
+#define G_RATECONTROL_QP_P_INITIAL "RateControl.QP.P.Initial"
+#define G_RATECONTROL_QP_B_INITIAL "RateControl.QP.B.Initial"
+
+#define G_KEYFRAMES "KeyFrames"
+#define G_KEYFRAMES_INTERVALTYPE "KeyFrames.IntervalType"
+#define G_KEYFRAMES_INTERVALTYPE_(x) "KeyFrames.IntervalType." D_VSTR(x)
+#define G_KEYFRAMES_INTERVAL "KeyFrames.Interval"
+#define G_KEYFRAMES_INTERVAL_SECONDS "KeyFrames.Interval.Seconds"
+#define G_KEYFRAMES_INTERVAL_FRAMES "KeyFrames.Interval.Frames"

source/ui/debug_handler.cpp

@@ -0,0 +1,205 @@
+// FFMPEG Video Encoder Integration for OBS Studio
+// Copyright (C) 2018 - 2019 Michael Fabian Dirks
+//
+// This program is free software; you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation; either version 2 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program; if not, write to the Free Software
+// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+
+#include "debug_handler.hpp"
+#include <map>
+#include <string>
+#include <utility>
+#include "handler.hpp"
+#include "plugin.hpp"
+#include "utility.hpp"
+
+extern "C" {
+#include <obs-properties.h>
+#pragma warning(push)
+#pragma warning(disable : 4244)
+#include <libavutil/opt.h>
+#pragma warning(pop)
+}
+
+void obsffmpeg::ui::debug_handler::get_defaults(obs_data_t*, AVCodec*, AVCodecContext*) {}
+
+template<typename T>
+std::string to_string(T value){};
+
+template<>
+std::string to_string(int64_t value)
+{
+	std::vector<char> buf(32);
+	snprintf(buf.data(), buf.size(), "%lld", value);
+	return std::string(buf.data(), buf.data() + buf.size());
+}
+
+template<>
+std::string to_string(uint64_t value)
+{
+	std::vector<char> buf(32);
+	snprintf(buf.data(), buf.size(), "%llu", value);
+	return std::string(buf.data(), buf.data() + buf.size());
+}
+
+template<>
+std::string to_string(double_t value)
+{
+	std::vector<char> buf(32);
+	snprintf(buf.data(), buf.size(), "%f", value);
+	return std::string(buf.data(), buf.data() + buf.size());
+}
+
+void obsffmpeg::ui::debug_handler::get_properties(obs_properties_t*, AVCodec* codec, AVCodecContext* context)
+{
+	if (context)
+		return;
+
+	AVCodecContext* ctx = avcodec_alloc_context3(codec);
+	if (!ctx->priv_data) {
+		avcodec_free_context(&ctx);
+		return;
+	}
+
+	PLOG_INFO("Options for '%s':", codec->name);
+
+	std::pair<AVOptionType, std::string> opt_type_name[] = {
+	    {AV_OPT_TYPE_FLAGS, "Flags"},
+	    {AV_OPT_TYPE_INT, "Int"},
+	    {AV_OPT_TYPE_INT64, "Int64"},
+	    {AV_OPT_TYPE_DOUBLE, "Double"},
+	    {AV_OPT_TYPE_FLOAT, "Float"},
+	    {AV_OPT_TYPE_STRING, "String"},
+	    {AV_OPT_TYPE_RATIONAL, "Rational"},
+	    {AV_OPT_TYPE_BINARY, "Binary"},
+	    {AV_OPT_TYPE_DICT, "Dictionary"},
+	    {AV_OPT_TYPE_UINT64, "Unsigned Int64"},
+	    {AV_OPT_TYPE_CONST, "Constant"},
+	    {AV_OPT_TYPE_IMAGE_SIZE, "Image Size"},
+	    {AV_OPT_TYPE_PIXEL_FMT, "Pixel Format"},
+	    {AV_OPT_TYPE_SAMPLE_FMT, "Sample Format"},
+	    {AV_OPT_TYPE_VIDEO_RATE, "Video Rate"},
+	    {AV_OPT_TYPE_DURATION, "Duration"},
+	    {AV_OPT_TYPE_COLOR, "Color"},
+	    {AV_OPT_TYPE_CHANNEL_LAYOUT, "Layout"},
+	    {AV_OPT_TYPE_BOOL, "Bool"},
+	};
+	std::map<std::string, AVOptionType> unit_types;
+
+	const AVOption* opt = nullptr;
+	while ((opt = av_opt_next(ctx->priv_data, opt)) != nullptr) {
+		std::string type_name = "";
+		for (auto kv : opt_type_name) {
+			if (opt->type == kv.first) {
+				type_name = kv.second;
+				break;
+			}
+		}
+
+		if (opt->type == AV_OPT_TYPE_CONST) {
+			if (opt->unit == nullptr) {
+				PLOG_INFO("  Constant '%s' and help text '%s' with unknown settings.", opt->name,
+				          opt->help);
+			} else {
+				auto unit_type = unit_types.find(opt->unit);
+				if (unit_type == unit_types.end()) {
+					PLOG_INFO("  [%s] Flag '%s' and help text '%s' with value '%lld'.", opt->unit,
+					          opt->name, opt->help, opt->default_val.i64);
+				} else {
+					std::string out;
+					switch (unit_type->second) {
+					case AV_OPT_TYPE_BOOL:
+						out = opt->default_val.i64 ? "true" : "false";
+						break;
+					case AV_OPT_TYPE_INT:
+						out = to_string(opt->default_val.i64);
+						break;
+					case AV_OPT_TYPE_UINT64:
+						out = to_string(static_cast<uint64_t>(opt->default_val.i64));
+						break;
+					case AV_OPT_TYPE_FLAGS:
+						out = to_string(static_cast<uint64_t>(opt->default_val.i64));
+						break;
+					case AV_OPT_TYPE_FLOAT:
+					case AV_OPT_TYPE_DOUBLE:
+						out = to_string(opt->default_val.dbl);
+						break;
+					case AV_OPT_TYPE_STRING:
+						out = opt->default_val.str;
+						break;
+					case AV_OPT_TYPE_BINARY:
+					case AV_OPT_TYPE_IMAGE_SIZE:
+					case AV_OPT_TYPE_PIXEL_FMT:
+					case AV_OPT_TYPE_SAMPLE_FMT:
+					case AV_OPT_TYPE_VIDEO_RATE:
+					case AV_OPT_TYPE_DURATION:
+					case AV_OPT_TYPE_COLOR:
+					case AV_OPT_TYPE_CHANNEL_LAYOUT:
+						break;
+					}
+
+					PLOG_INFO("  [%s] Constant '%s' and help text '%s' with value '%s'.", opt->unit,
+					          opt->name, opt->help, out.c_str());
+				}
+			}
+		} else {
+			if (opt->unit != nullptr) {
+				unit_types.emplace(opt->name, opt->type);
+			}
+
+			std::string minimum = "", maximum = "", out;
+			minimum = to_string(opt->min);
+			maximum = to_string(opt->max);
+			{
+				switch (opt->type) {
+				case AV_OPT_TYPE_BOOL:
+					out = opt->default_val.i64 ? "true" : "false";
+					break;
+				case AV_OPT_TYPE_INT:
+					out = to_string(opt->default_val.i64);
+					break;
+				case AV_OPT_TYPE_UINT64:
+					out = to_string(static_cast<uint64_t>(opt->default_val.i64));
+					break;
+				case AV_OPT_TYPE_FLAGS:
+					out = to_string(static_cast<uint64_t>(opt->default_val.i64));
+					break;
+				case AV_OPT_TYPE_FLOAT:
+				case AV_OPT_TYPE_DOUBLE:
+					out = to_string(opt->default_val.dbl);
+					break;
+				case AV_OPT_TYPE_STRING:
+					out = opt->default_val.str ? opt->default_val.str : "<invalid>";
+					break;
+				case AV_OPT_TYPE_BINARY:
+				case AV_OPT_TYPE_IMAGE_SIZE:
+				case AV_OPT_TYPE_PIXEL_FMT:
+				case AV_OPT_TYPE_SAMPLE_FMT:
+				case AV_OPT_TYPE_VIDEO_RATE:
+				case AV_OPT_TYPE_DURATION:
+				case AV_OPT_TYPE_COLOR:
+				case AV_OPT_TYPE_CHANNEL_LAYOUT:
+					break;
+				}
+			}
+
+			PLOG_INFO(
+			    "  Option '%s'%s%s%s with help '%s' of type '%s' with default value '%s', minimum '%s' and maximum '%s'.",
+			    opt->name, opt->unit ? " with unit (" : "", opt->unit ? opt->unit : "",
+			    opt->unit ? ")" : "", opt->help, type_name.c_str(), out.c_str(), minimum.c_str(),
+			    maximum.c_str());
+		}
+	}
+}
+
+void obsffmpeg::ui::debug_handler::update(obs_data_t*, AVCodec*, AVCodecContext*) {}

source/ui/debug_handler.hpp

@@ -0,0 +1,34 @@
+// FFMPEG Video Encoder Integration for OBS Studio
+// Copyright (C) 2018 - 2019 Michael Fabian Dirks
+//
+// This program is free software; you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation; either version 2 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program; if not, write to the Free Software
+// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+
+#pragma once
+#include "handler.hpp"
+
+namespace obsffmpeg {
+	namespace ui {
+		class debug_handler : public handler {
+			public:
+			virtual void get_defaults(obs_data_t* settings, AVCodec* codec,
+			                          AVCodecContext* context) override;
+
+			virtual void get_properties(obs_properties_t* props, AVCodec* codec,
+			                            AVCodecContext* context) override;
+
+			virtual void update(obs_data_t* settings, AVCodec* codec, AVCodecContext* context) override;
+		};
+	} // namespace ui
+} // namespace obsffmpeg

source/ui/handler.cpp

@@ -0,0 +1,18 @@
+// FFMPEG Video Encoder Integration for OBS Studio
+// Copyright (C) 2018 - 2019 Michael Fabian Dirks
+//
+// This program is free software; you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation; either version 2 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program; if not, write to the Free Software
+// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+
+#include "handler.hpp"

source/ui/handler.hpp

@@ -0,0 +1,40 @@
+// FFMPEG Video Encoder Integration for OBS Studio
+// Copyright (C) 2018 - 2019 Michael Fabian Dirks
+//
+// This program is free software; you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation; either version 2 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program; if not, write to the Free Software
+// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+
+#pragma once
+
+extern "C" {
+#include <obs-properties.h>
+#pragma warning(push)
+#pragma warning(disable : 4244)
+#include <libavcodec/avcodec.h>
+#pragma warning(pop)
+}
+
+namespace obsffmpeg {
+	namespace ui {
+		class handler {
+			public:
+			virtual void get_defaults(obs_data_t* settings, AVCodec* codec, AVCodecContext* context) = 0;
+
+			virtual void get_properties(obs_properties_t* props, AVCodec* codec,
+			                            AVCodecContext* context) = 0;
+
+			virtual void update(obs_data_t* settings, AVCodec* codec, AVCodecContext* context) = 0;
+		};
+	} // namespace ui
+} // namespace obsffmpeg

source/ui/nvenc_hevc_handler.cpp

@@ -0,0 +1,171 @@
+// FFMPEG Video Encoder Integration for OBS Studio
+// Copyright (C) 2018 - 2019 Michael Fabian Dirks
+//
+// This program is free software; you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation; either version 2 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program; if not, write to the Free Software
+// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+
+#include "nvenc_hevc_handler.hpp"
+#include "codecs/hevc.hpp"
+#include "nvenc_shared.hpp"
+#include "plugin.hpp"
+#include "strings.hpp"
+#include "utility.hpp"
+
+extern "C" {
+#include <obs-module.h>
+#pragma warning(push)
+#pragma warning(disable : 4244)
+#include <libavutil/opt.h>
+#pragma warning(pop)
+}
+
+/* Missing Options:
+
+Seem to be covered by initQP_* instead.
+- [obs-ffmpeg-encoder]   Option 'cq' with help 'Set target quality level (0 to 51, 0 means automatic) for constant quality mode in VBR rate control' of type 'Float' with default value '0.000000', minimum '0.000000' and maximum '51.000000'.
+- [obs-ffmpeg-encoder]   Option 'qp' with help 'Constant quantization parameter rate control method' of type 'Int' with default value '-1', minimum '-1.000000' and maximum '51.000000'.
+
+Not sure what there are useful for.
+[obs-ffmpeg-encoder]   Option 'aud' with help 'Use access unit delimiters' of type 'Bool' with default value 'false', minimum '0.000000' and maximum '1.000000'.
+[obs-ffmpeg-encoder]   Option 'surfaces' with help 'Number of concurrent surfaces' of type 'Int' with default value '0', minimum '0.000000' and maximum '64.000000'.
+[obs-ffmpeg-encoder]   Option 'delay' with help 'Delay frame output by the given amount of frames' of type 'Int' with default value '2147483647', minimum '0.000000' and maximum '2147483647.000000'.
+
+Should probably add this.
+[obs-ffmpeg-encoder]   Option 'gpu' with unit (gpu) with help 'Selects which NVENC capable GPU to use. First GPU is 0, second is 1, and so on.' of type 'Int' with default value '-1', minimum '-2.000000' and maximum '2147483647.000000'.
+[obs-ffmpeg-encoder]   [gpu] Constant 'any' and help text 'Pick the first device available' with value '-1'.
+[obs-ffmpeg-encoder]   [gpu] Constant 'list' and help text 'List the available devices' with value '-2'.
+
+Useless except for strict_gop maybe?
+[obs-ffmpeg-encoder]   Option 'forced-idr' with help 'If forcing keyframes, force them as IDR frames.' of type 'Bool' with default value 'false', minimum '-1.000000' and maximum '1.000000'.
+[obs-ffmpeg-encoder]   Option 'strict_gop' with help 'Set 1 to minimize GOP-to-GOP rate fluctuations' of type 'Bool' with default value 'false', minimum '0.000000' and maximum '1.000000'.
+[obs-ffmpeg-encoder]   Option 'bluray-compat' with help 'Bluray compatibility workarounds' of type 'Bool' with default value 'false', minimum '0.000000' and maximum '1.000000'.
+*/
+
+INITIALIZER(nvenc_hevc_handler_init)
+{
+	obsffmpeg::initializers.push_back([]() {
+		obsffmpeg::register_codec_handler("hevc_nvenc", std::make_shared<obsffmpeg::ui::nvenc_hevc_handler>());
+	});
+};
+
+void obsffmpeg::ui::nvenc_hevc_handler::get_defaults(obs_data_t* settings, AVCodec* codec, AVCodecContext* context)
+{
+	nvenc::get_defaults(settings, codec, context);
+
+	obs_data_set_default_int(settings, P_HEVC_PROFILE, static_cast<int64_t>(codecs::hevc::profile::MAIN));
+	obs_data_set_default_int(settings, P_HEVC_TIER, static_cast<int64_t>(codecs::hevc::profile::MAIN));
+	obs_data_set_default_int(settings, P_HEVC_LEVEL, static_cast<int64_t>(codecs::hevc::level::UNKNOWN));
+}
+
+void obsffmpeg::ui::nvenc_hevc_handler::get_properties(obs_properties_t* props, AVCodec* codec, AVCodecContext* context)
+{
+	if (!context) {
+		this->get_encoder_properties(props, codec);
+	} else {
+		this->get_runtime_properties(props, codec, context);
+	}
+}
+
+void obsffmpeg::ui::nvenc_hevc_handler::update(obs_data_t* settings, AVCodec* codec, AVCodecContext* context)
+{
+	nvenc::update(settings, codec, context);
+
+	{ // HEVC Options
+		codecs::hevc::profile profile =
+		    static_cast<codecs::hevc::profile>(obs_data_get_int(settings, P_HEVC_PROFILE));
+		switch (profile) {
+		case codecs::hevc::profile::MAIN:
+		case codecs::hevc::profile::MAIN10:
+		case codecs::hevc::profile::RANGE_EXTENDED:
+			av_opt_set_int(context->priv_data, "profile", static_cast<int64_t>(profile), 0);
+			break;
+		default:
+			av_opt_set_int(context->priv_data, "profile", static_cast<int64_t>(codecs::hevc::profile::MAIN),
+			               0);
+			break;
+		}
+
+		codecs::hevc::tier tier = static_cast<codecs::hevc::tier>(obs_data_get_int(settings, P_HEVC_TIER));
+		switch (tier) {
+		case codecs::hevc::tier::MAIN:
+		case codecs::hevc::tier::HIGH:
+			av_opt_set_int(context->priv_data, "tier", static_cast<int64_t>(tier), 0);
+			break;
+		default:
+			av_opt_set_int(context->priv_data, "tier", static_cast<int64_t>(codecs::hevc::tier::MAIN), 0);
+			break;
+		}
+
+		codecs::hevc::level level = static_cast<codecs::hevc::level>(obs_data_get_int(settings, P_HEVC_LEVEL));
+		if (level != codecs::hevc::level::UNKNOWN) {
+			av_opt_set_int(context->priv_data, "level", static_cast<int64_t>(level), 0);
+		} else {
+			av_opt_set_int(context->priv_data, "level", static_cast<int64_t>(0), 0); // Automatic
+		}
+	}
+}
+
+void obsffmpeg::ui::nvenc_hevc_handler::get_encoder_properties(obs_properties_t* props, AVCodec* codec)
+{
+	nvenc::get_properties_pre(props, codec);
+
+	{
+		obs_properties_t* grp = props;
+		if (!obsffmpeg::are_property_groups_broken()) {
+			grp = obs_properties_create();
+			obs_properties_add_group(props, P_HEVC, TRANSLATE(P_HEVC), OBS_GROUP_NORMAL, grp);
+		}
+
+		{
+			auto p = obs_properties_add_list(grp, P_HEVC_PROFILE, TRANSLATE(P_HEVC_PROFILE),
+			                                 OBS_COMBO_TYPE_LIST, OBS_COMBO_FORMAT_INT);
+			obs_property_set_long_description(p, TRANSLATE(DESC(P_HEVC_PROFILE)));
+			obs_property_list_add_int(p, TRANSLATE(G_STATE_DEFAULT),
+			                          static_cast<int64_t>(codecs::hevc::profile::UNKNOWN));
+			for (auto kv : codecs::hevc::profiles) {
+				std::string trans = std::string(P_HEVC_PROFILE) + "." + kv.second;
+				obs_property_list_add_int(p, TRANSLATE(trans.c_str()), static_cast<int64_t>(kv.first));
+			}
+		}
+		{
+			auto p = obs_properties_add_list(grp, P_HEVC_TIER, TRANSLATE(P_HEVC_TIER), OBS_COMBO_TYPE_LIST,
+			                                 OBS_COMBO_FORMAT_INT);
+			obs_property_set_long_description(p, TRANSLATE(DESC(P_HEVC_TIER)));
+			obs_property_list_add_int(p, TRANSLATE(G_STATE_DEFAULT),
+			                          static_cast<int64_t>(codecs::hevc::tier::UNKNOWN));
+			for (auto kv : codecs::hevc::profile_tiers) {
+				std::string trans = std::string(P_HEVC_TIER) + "." + kv.second;
+				obs_property_list_add_int(p, TRANSLATE(trans.c_str()), static_cast<int64_t>(kv.first));
+			}
+		}
+		{
+			auto p = obs_properties_add_list(grp, P_HEVC_LEVEL, TRANSLATE(P_HEVC_LEVEL),
+			                                 OBS_COMBO_TYPE_LIST, OBS_COMBO_FORMAT_INT);
+			obs_property_set_long_description(p, TRANSLATE(DESC(P_HEVC_LEVEL)));
+			obs_property_list_add_int(p, TRANSLATE(G_STATE_AUTOMATIC),
+			                          static_cast<int64_t>(codecs::hevc::level::UNKNOWN));
+			for (auto kv : codecs::hevc::levels) {
+				obs_property_list_add_int(p, kv.second.c_str(), static_cast<int64_t>(kv.first));
+			}
+		}
+	}
+
+	nvenc::get_properties_post(props, codec);
+}
+
+void obsffmpeg::ui::nvenc_hevc_handler::get_runtime_properties(obs_properties_t* props, AVCodec* codec,
+                                                               AVCodecContext* context)
+{
+	nvenc::get_runtime_properties(props, codec, context);
+}

source/ui/nvenc_hevc_handler.hpp

@@ -0,0 +1,47 @@
+// FFMPEG Video Encoder Integration for OBS Studio
+// Copyright (C) 2018 - 2019 Michael Fabian Dirks
+//
+// This program is free software; you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation; either version 2 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program; if not, write to the Free Software
+// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+
+#pragma once
+#include "handler.hpp"
+
+extern "C" {
+#include <obs-properties.h>
+#pragma warning(push)
+#pragma warning(disable : 4244)
+#include <libavcodec/avcodec.h>
+#pragma warning(pop)
+}
+
+namespace obsffmpeg {
+	namespace ui {
+		class nvenc_hevc_handler : public handler {
+			public:
+			virtual void get_defaults(obs_data_t* settings, AVCodec* codec,
+			                          AVCodecContext* context) override;
+
+			virtual void get_properties(obs_properties_t* props, AVCodec* codec,
+			                            AVCodecContext* context) override;
+
+			virtual void update(obs_data_t* settings, AVCodec* codec, AVCodecContext* context) override;
+
+			private:
+			void get_encoder_properties(obs_properties_t* props, AVCodec* codec);
+
+			void get_runtime_properties(obs_properties_t* props, AVCodec* codec, AVCodecContext* context);
+		};
+	} // namespace ui
+} // namespace obsffmpeg

source/ui/nvenc_shared.cpp

@@ -0,0 +1,665 @@
+// FFMPEG Video Encoder Integration for OBS Studio
+// Copyright (C) 2018 - 2019 Michael Fabian Dirks
+//
+// This program is free software; you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation; either version 2 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program; if not, write to the Free Software
+// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+
+#include "nvenc_shared.hpp"
+#include "codecs/hevc.hpp"
+#include "plugin.hpp"
+#include "strings.hpp"
+#include "utility.hpp"
+
+extern "C" {
+#include <obs-module.h>
+#pragma warning(push)
+#pragma warning(disable : 4244)
+#include <libavutil/opt.h>
+#pragma warning(pop)
+}
+
+#define P_PRESET "NVENC.Preset"
+#define P_PRESET_(x) P_PRESET "." D_VSTR(x)
+
+#define P_RATECONTROL "NVENC.RateControl"
+#define P_RATECONTROL_MODE P_RATECONTROL ".Mode"
+#define P_RATECONTROL_MODE_(x) P_RATECONTROL_MODE "." D_VSTR(x)
+#define P_RATECONTROL_TWOPASS P_RATECONTROL ".TwoPass"
+#define P_RATECONTROL_LOOKAHEAD P_RATECONTROL ".LookAhead"
+#define P_RATECONTROL_ADAPTIVEI P_RATECONTROL ".AdaptiveI"
+#define P_RATECONTROL_ADAPTIVEB P_RATECONTROL ".AdaptiveB"
+
+#define P_RATECONTROL_BITRATE P_RATECONTROL ".Bitrate"
+#define P_RATECONTROL_BITRATE_TARGET P_RATECONTROL_BITRATE ".Target"
+#define P_RATECONTROL_BITRATE_MAXIMUM P_RATECONTROL_BITRATE ".Maximum"
+
+#define P_RATECONTROL_QUALITY P_RATECONTROL ".Quality"
+#define P_RATECONTROL_QUALITY_MINIMUM P_RATECONTROL_QUALITY ".Minimum"
+#define P_RATECONTROL_QUALITY_MAXIMUM P_RATECONTROL_QUALITY ".Maximum"
+
+#define P_AQ "NVENC.AQ"
+#define P_AQ_SPATIAL P_AQ ".Spatial"
+#define P_AQ_TEMPORAL P_AQ ".Temporal"
+#define P_AQ_STRENGTH P_AQ ".Strength"
+
+#define P_OTHER "NVENC.Other"
+#define P_OTHER_BFRAMES P_OTHER ".BFrames"
+#define P_OTHER_BFRAME_REFERENCEMODE P_OTHER ".BFrameReferenceMode"
+#define P_OTHER_ZEROLATENCY P_OTHER ".ZeroLatency"
+#define P_OTHER_WEIGHTED_PREDICTION P_OTHER ".WeightedPrediction"
+#define P_OTHER_NONREFERENCE_PFRAMES P_OTHER ".NonReferencePFrames"
+
+using namespace obsffmpeg::nvenc;
+
+std::map<preset, std::string> obsffmpeg::nvenc::presets{
+    {preset::DEFAULT, P_PRESET_(Default)},
+    {preset::SLOW, P_PRESET_(Slow)},
+    {preset::MEDIUM, P_PRESET_(Medium)},
+    {preset::FAST, P_PRESET_(Fast)},
+    {preset::HIGH_PERFORMANCE, P_PRESET_(HighPerformance)},
+    {preset::HIGH_QUALITY, P_PRESET_(HighQuality)},
+    {preset::BLURAYDISC, P_PRESET_(BluRayDisc)},
+    {preset::LOW_LATENCY, P_PRESET_(LowLatency)},
+    {preset::LOW_LATENCY_HIGH_PERFORMANCE, P_PRESET_(LowLatencyHighPerformance)},
+    {preset::LOW_LATENCY_HIGH_QUALITY, P_PRESET_(LowLatencyHighQuality)},
+    {preset::LOSSLESS, P_PRESET_(Lossless)},
+    {preset::LOSSLESS_HIGH_PERFORMANCE, P_PRESET_(LosslessHighPerformance)},
+};
+
+std::map<preset, std::string> obsffmpeg::nvenc::preset_to_opt{
+    {preset::DEFAULT, "default"},
+    {preset::SLOW, "slow"},
+    {preset::MEDIUM, "medium"},
+    {preset::FAST, "fast"},
+    {preset::HIGH_PERFORMANCE, "hp"},
+    {preset::HIGH_QUALITY, "hq"},
+    {preset::BLURAYDISC, "bd"},
+    {preset::LOW_LATENCY, "ll"},
+    {preset::LOW_LATENCY_HIGH_PERFORMANCE, "llhp"},
+    {preset::LOW_LATENCY_HIGH_QUALITY, "llhq"},
+    {preset::LOSSLESS, "lossless"},
+    {preset::LOSSLESS_HIGH_PERFORMANCE, "losslesshp"},
+};
+
+std::map<ratecontrolmode, std::string> obsffmpeg::nvenc::ratecontrolmodes{
+    {ratecontrolmode::CQP, P_RATECONTROL_MODE_(CQP)},
+    {ratecontrolmode::VBR, P_RATECONTROL_MODE_(VBR)},
+    {ratecontrolmode::VBR_HQ, P_RATECONTROL_MODE_(VBR_HQ)},
+    {ratecontrolmode::CBR, P_RATECONTROL_MODE_(CBR)},
+    {ratecontrolmode::CBR_HQ, P_RATECONTROL_MODE_(CBR_HQ)},
+    {ratecontrolmode::CBR_LD_HQ, P_RATECONTROL_MODE_(CBR_LD_HQ)},
+};
+
+std::map<ratecontrolmode, std::string> obsffmpeg::nvenc::ratecontrolmode_to_opt{
+    {ratecontrolmode::CQP, "const_qp"}, {ratecontrolmode::VBR, "vbr"},       {ratecontrolmode::VBR_HQ, "vbr_hq"},
+    {ratecontrolmode::CBR, "cbr"},      {ratecontrolmode::CBR_HQ, "cbr_hq"}, {ratecontrolmode::CBR_LD_HQ, "cbr_ld_hq"},
+};
+
+std::map<b_ref_mode, std::string> obsffmpeg::nvenc::b_ref_modes{
+    {b_ref_mode::DISABLED, G_STATE_DISABLED},
+    {b_ref_mode::EACH, P_OTHER_BFRAME_REFERENCEMODE ".Each"},
+    {b_ref_mode::MIDDLE, P_OTHER_BFRAME_REFERENCEMODE ".Middle"},
+};
+
+std::map<b_ref_mode, std::string> obsffmpeg::nvenc::b_ref_mode_to_opt{
+    {b_ref_mode::DISABLED, "disabled"},
+    {b_ref_mode::EACH, "each"},
+    {b_ref_mode::MIDDLE, "middle"},
+};
+
+void obsffmpeg::nvenc::get_defaults(obs_data_t* settings, AVCodec*, AVCodecContext*)
+{
+	obs_data_set_default_int(settings, P_PRESET, static_cast<int64_t>(preset::DEFAULT));
+
+	obs_data_set_default_int(settings, P_RATECONTROL_MODE, static_cast<int64_t>(ratecontrolmode::CBR_HQ));
+	obs_data_set_default_int(settings, P_RATECONTROL_TWOPASS, -1);
+	obs_data_set_default_int(settings, P_RATECONTROL_LOOKAHEAD, 0);
+	obs_data_set_default_bool(settings, P_RATECONTROL_ADAPTIVEI, true);
+	obs_data_set_default_bool(settings, P_RATECONTROL_ADAPTIVEB, true);
+
+	obs_data_set_default_int(settings, P_RATECONTROL_BITRATE_TARGET, 6000);
+	obs_data_set_default_int(settings, P_RATECONTROL_BITRATE_MAXIMUM, 6000);
+	obs_data_set_default_int(settings, G_RATECONTROL_BUFFERSIZE, 12000);
+
+	obs_data_set_default_int(settings, P_RATECONTROL_QUALITY_MINIMUM, 51);
+	obs_data_set_default_int(settings, P_RATECONTROL_QUALITY_MAXIMUM, -1);
+
+	obs_data_set_default_int(settings, G_RATECONTROL_QP_I, 21);
+	obs_data_set_default_int(settings, G_RATECONTROL_QP_P, 21);
+	obs_data_set_default_int(settings, G_RATECONTROL_QP_B, 21);
+	obs_data_set_default_int(settings, G_RATECONTROL_QP_I_INITIAL, -1);
+	obs_data_set_default_int(settings, G_RATECONTROL_QP_P_INITIAL, -1);
+	obs_data_set_default_int(settings, G_RATECONTROL_QP_B_INITIAL, -1);
+
+	obs_data_set_default_int(settings, G_KEYFRAMES_INTERVALTYPE, 0);
+	obs_data_set_default_double(settings, G_KEYFRAMES_INTERVAL_SECONDS, 2.0);
+	obs_data_set_default_int(settings, G_KEYFRAMES_INTERVAL_FRAMES, 300);
+
+	obs_data_set_default_bool(settings, P_AQ_SPATIAL, true);
+	obs_data_set_default_int(settings, P_AQ_STRENGTH, 8);
+	obs_data_set_default_bool(settings, P_AQ_TEMPORAL, true);
+
+	obs_data_set_default_int(settings, P_OTHER_BFRAMES, 2);
+	obs_data_set_default_int(settings, P_OTHER_BFRAME_REFERENCEMODE, static_cast<int64_t>(b_ref_mode::DISABLED));
+	obs_data_set_default_bool(settings, P_OTHER_ZEROLATENCY, false);
+	obs_data_set_default_bool(settings, P_OTHER_WEIGHTED_PREDICTION, false);
+	obs_data_set_default_bool(settings, P_OTHER_NONREFERENCE_PFRAMES, false);
+}
+
+static bool modified_ratecontrol(obs_properties_t* props, obs_property_t*, obs_data_t* settings)
+{
+	using namespace obsffmpeg::nvenc;
+
+	bool have_bitrate     = false;
+	bool have_bitrate_max = false;
+	bool have_quality     = false;
+	bool have_qp          = false;
+	bool have_qp_init     = false;
+
+	ratecontrolmode rc = static_cast<ratecontrolmode>(obs_data_get_int(settings, P_RATECONTROL_MODE));
+	switch (rc) {
+	case ratecontrolmode::CQP:
+		have_qp = true;
+		break;
+	case ratecontrolmode::CBR:
+	case ratecontrolmode::CBR_HQ:
+	case ratecontrolmode::CBR_LD_HQ:
+		have_bitrate = true;
+		break;
+	case ratecontrolmode::VBR:
+	case ratecontrolmode::VBR_HQ:
+		have_bitrate     = true;
+		have_bitrate_max = true;
+		have_quality     = true;
+		have_qp_init     = true;
+		break;
+	}
+
+	obs_property_set_visible(obs_properties_get(props, P_RATECONTROL_BITRATE), have_bitrate || have_bitrate_max);
+	obs_property_set_visible(obs_properties_get(props, P_RATECONTROL_BITRATE_TARGET), have_bitrate);
+	obs_property_set_visible(obs_properties_get(props, P_RATECONTROL_BITRATE_MAXIMUM), have_bitrate_max);
+	obs_property_set_visible(obs_properties_get(props, G_RATECONTROL_BUFFERSIZE), have_bitrate || have_bitrate_max);
+
+	obs_property_set_visible(obs_properties_get(props, P_RATECONTROL_QUALITY), have_quality);
+	obs_property_set_visible(obs_properties_get(props, P_RATECONTROL_QUALITY_MINIMUM), have_quality);
+	obs_property_set_visible(obs_properties_get(props, P_RATECONTROL_QUALITY_MAXIMUM), have_quality);
+
+	obs_property_set_visible(obs_properties_get(props, G_RATECONTROL_QP_I), have_qp);
+	obs_property_set_visible(obs_properties_get(props, G_RATECONTROL_QP_P), have_qp);
+	obs_property_set_visible(obs_properties_get(props, G_RATECONTROL_QP_B), have_qp);
+	obs_property_set_visible(obs_properties_get(props, G_RATECONTROL_QP_I_INITIAL), have_qp_init);
+	obs_property_set_visible(obs_properties_get(props, G_RATECONTROL_QP_P_INITIAL), have_qp_init);
+	obs_property_set_visible(obs_properties_get(props, G_RATECONTROL_QP_B_INITIAL), have_qp_init);
+
+	return true;
+}
+
+static bool modified_quality(obs_properties_t* props, obs_property_t*, obs_data_t* settings)
+{
+	bool enabled = obs_data_get_bool(settings, P_RATECONTROL_QUALITY);
+	obs_property_set_enabled(obs_properties_get(props, P_RATECONTROL_QUALITY_MINIMUM), enabled);
+	obs_property_set_enabled(obs_properties_get(props, P_RATECONTROL_QUALITY_MAXIMUM), enabled);
+	return true;
+}
+
+static bool modified_keyframes(obs_properties_t* props, obs_property_t*, obs_data_t* settings)
+{
+	bool is_seconds = obs_data_get_int(settings, G_KEYFRAMES_INTERVALTYPE) == 0;
+	obs_property_set_visible(obs_properties_get(props, G_KEYFRAMES_INTERVAL_FRAMES), !is_seconds);
+	obs_property_set_visible(obs_properties_get(props, G_KEYFRAMES_INTERVAL_SECONDS), is_seconds);
+	return true;
+}
+
+static bool modified_aq(obs_properties_t* props, obs_property_t*, obs_data_t* settings)
+{
+	bool spatial_aq = obs_data_get_bool(settings, P_AQ_SPATIAL);
+	obs_property_set_visible(obs_properties_get(props, P_AQ_STRENGTH), spatial_aq);
+	return true;
+}
+
+void obsffmpeg::nvenc::get_properties_pre(obs_properties_t* props, AVCodec*)
+{
+	{
+		auto p = obs_properties_add_list(props, P_PRESET, TRANSLATE(P_PRESET), OBS_COMBO_TYPE_LIST,
+		                                 OBS_COMBO_FORMAT_INT);
+		obs_property_set_long_description(p, TRANSLATE(DESC(P_PRESET)));
+		for (auto kv : presets) {
+			obs_property_list_add_int(p, TRANSLATE(kv.second.c_str()), static_cast<int64_t>(kv.first));
+		}
+	}
+}
+
+void obsffmpeg::nvenc::get_properties_post(obs_properties_t* props, AVCodec* codec)
+{
+	{ // Rate Control
+		obs_properties_t* grp = props;
+		if (!obsffmpeg::are_property_groups_broken()) {
+			grp = obs_properties_create();
+			obs_properties_add_group(props, P_RATECONTROL, TRANSLATE(P_RATECONTROL), OBS_GROUP_NORMAL, grp);
+		}
+
+		{
+			auto p = obs_properties_add_list(grp, P_RATECONTROL_MODE, TRANSLATE(P_RATECONTROL_MODE),
+			                                 OBS_COMBO_TYPE_LIST, OBS_COMBO_FORMAT_INT);
+			obs_property_set_long_description(p, TRANSLATE(DESC(P_RATECONTROL_MODE)));
+			obs_property_set_modified_callback(p, modified_ratecontrol);
+			for (auto kv : ratecontrolmodes) {
+				obs_property_list_add_int(p, TRANSLATE(kv.second.c_str()),
+				                          static_cast<int64_t>(kv.first));
+			}
+		}
+
+		{
+			auto p = obs_properties_add_list(grp, P_RATECONTROL_TWOPASS, TRANSLATE(P_RATECONTROL_TWOPASS),
+			                                 OBS_COMBO_TYPE_LIST, OBS_COMBO_FORMAT_INT);
+			obs_property_set_long_description(p, TRANSLATE(DESC(P_RATECONTROL_TWOPASS)));
+			obs_property_list_add_int(p, TRANSLATE(G_STATE_DEFAULT), -1);
+			obs_property_list_add_int(p, TRANSLATE(G_STATE_DISABLED), 0);
+			obs_property_list_add_int(p, TRANSLATE(G_STATE_ENABLED), 1);
+		}
+
+		{
+			auto p = obs_properties_add_int_slider(grp, P_RATECONTROL_LOOKAHEAD,
+			                                       TRANSLATE(P_RATECONTROL_LOOKAHEAD), 0, 60, 1);
+			obs_property_set_long_description(p, TRANSLATE(DESC(P_RATECONTROL_LOOKAHEAD)));
+			obs_property_int_set_suffix(p, " frames");
+		}
+		{
+			auto p =
+			    obs_properties_add_bool(grp, P_RATECONTROL_ADAPTIVEI, TRANSLATE(P_RATECONTROL_ADAPTIVEI));
+			obs_property_set_long_description(p, TRANSLATE(DESC(P_RATECONTROL_ADAPTIVEI)));
+		}
+		if (strcmp(codec->name, "h264_nvenc") == 0) {
+			auto p =
+			    obs_properties_add_bool(grp, P_RATECONTROL_ADAPTIVEB, TRANSLATE(P_RATECONTROL_ADAPTIVEB));
+			obs_property_set_long_description(p, TRANSLATE(DESC(P_RATECONTROL_ADAPTIVEB)));
+		}
+
+		{
+			auto p = obs_properties_add_int_slider(grp, G_RATECONTROL_QP_I, TRANSLATE(G_RATECONTROL_QP_I),
+			                                       0, 51, 1);
+			obs_property_set_long_description(p, TRANSLATE(DESC(G_RATECONTROL_QP_I)));
+		}
+		{
+			auto p = obs_properties_add_int_slider(grp, G_RATECONTROL_QP_I_INITIAL,
+			                                       TRANSLATE(G_RATECONTROL_QP_I_INITIAL), -1, 51, 1);
+			obs_property_set_long_description(p, TRANSLATE(DESC(G_RATECONTROL_QP_I_INITIAL)));
+		}
+		{
+			auto p = obs_properties_add_int_slider(grp, G_RATECONTROL_QP_P, TRANSLATE(G_RATECONTROL_QP_P),
+			                                       0, 51, 1);
+			obs_property_set_long_description(p, TRANSLATE(DESC(G_RATECONTROL_QP_P)));
+		}
+		{
+			auto p = obs_properties_add_int_slider(grp, G_RATECONTROL_QP_P_INITIAL,
+			                                       TRANSLATE(G_RATECONTROL_QP_P_INITIAL), -1, 51, 1);
+			obs_property_set_long_description(p, TRANSLATE(DESC(G_RATECONTROL_QP_P_INITIAL)));
+		}
+		{
+			auto p = obs_properties_add_int_slider(grp, G_RATECONTROL_QP_B, TRANSLATE(G_RATECONTROL_QP_B),
+			                                       0, 51, 1);
+			obs_property_set_long_description(p, TRANSLATE(DESC(G_RATECONTROL_QP_B)));
+		}
+		{
+			auto p = obs_properties_add_int_slider(grp, G_RATECONTROL_QP_B_INITIAL,
+			                                       TRANSLATE(G_RATECONTROL_QP_B_INITIAL), -1, 51, 1);
+			obs_property_set_long_description(p, TRANSLATE(DESC(G_RATECONTROL_QP_B_INITIAL)));
+		}
+	}
+
+	{
+		obs_properties_t* grp = props;
+		if (!obsffmpeg::are_property_groups_broken()) {
+			grp = obs_properties_create();
+			obs_properties_add_group(props, P_RATECONTROL_BITRATE, TRANSLATE(P_RATECONTROL_BITRATE),
+			                         OBS_GROUP_NORMAL, grp);
+		}
+
+		{
+			auto p = obs_properties_add_int(grp, P_RATECONTROL_BITRATE_TARGET,
+			                                TRANSLATE(P_RATECONTROL_BITRATE_TARGET), 1,
+			                                std::numeric_limits<int32_t>::max(), 1);
+			obs_property_set_long_description(p, TRANSLATE(DESC(P_RATECONTROL_BITRATE_TARGET)));
+			obs_property_int_set_suffix(p, " kbit/s");
+		}
+		{
+			auto p = obs_properties_add_int(grp, P_RATECONTROL_BITRATE_MAXIMUM,
+			                                TRANSLATE(P_RATECONTROL_BITRATE_MAXIMUM), 0,
+			                                std::numeric_limits<int32_t>::max(), 1);
+			obs_property_set_long_description(p, TRANSLATE(DESC(P_RATECONTROL_BITRATE_MAXIMUM)));
+			obs_property_int_set_suffix(p, " kbit/s");
+		}
+		{
+			auto p =
+			    obs_properties_add_int(grp, G_RATECONTROL_BUFFERSIZE, TRANSLATE(G_RATECONTROL_BUFFERSIZE),
+			                           0, std::numeric_limits<int32_t>::max(), 1);
+			obs_property_set_long_description(p, TRANSLATE(DESC(G_RATECONTROL_BUFFERSIZE)));
+			obs_property_int_set_suffix(p, " kbit");
+		}
+	}
+
+	{
+		obs_properties_t* grp = props;
+		if (!obsffmpeg::are_property_groups_broken()) {
+			grp    = obs_properties_create();
+			auto p = obs_properties_add_group(props, P_RATECONTROL_QUALITY,
+			                                  TRANSLATE(P_RATECONTROL_QUALITY), OBS_GROUP_CHECKABLE, grp);
+			obs_property_set_modified_callback(p, modified_quality);
+		} else {
+			auto p =
+			    obs_properties_add_bool(props, P_RATECONTROL_QUALITY, TRANSLATE(P_RATECONTROL_QUALITY));
+			obs_property_set_modified_callback(p, modified_quality);
+		}
+
+		{
+			auto p = obs_properties_add_int_slider(grp, P_RATECONTROL_QUALITY_MINIMUM,
+			                                       TRANSLATE(P_RATECONTROL_QUALITY_MINIMUM), 0, 51, 1);
+			obs_property_set_long_description(p, TRANSLATE(DESC(P_RATECONTROL_QUALITY_MINIMUM)));
+		}
+		{
+			auto p = obs_properties_add_int_slider(grp, P_RATECONTROL_QUALITY_MAXIMUM,
+			                                       TRANSLATE(P_RATECONTROL_QUALITY_MAXIMUM), -1, 51, 1);
+			obs_property_set_long_description(p, TRANSLATE(DESC(P_RATECONTROL_QUALITY_MAXIMUM)));
+		}
+	}
+
+	{
+		obs_properties_t* grp = props;
+		if (!obsffmpeg::are_property_groups_broken()) {
+			grp = obs_properties_create();
+			obs_properties_add_group(props, G_KEYFRAMES, TRANSLATE(G_KEYFRAMES), OBS_GROUP_NORMAL, grp);
+		}
+
+		{
+			auto p =
+			    obs_properties_add_list(grp, G_KEYFRAMES_INTERVALTYPE, TRANSLATE(G_KEYFRAMES_INTERVALTYPE),
+			                            OBS_COMBO_TYPE_LIST, OBS_COMBO_FORMAT_INT);
+			obs_property_set_long_description(p, TRANSLATE(DESC(G_KEYFRAMES_INTERVALTYPE)));
+			obs_property_set_modified_callback(p, modified_keyframes);
+			obs_property_list_add_int(p, TRANSLATE(G_KEYFRAMES_INTERVALTYPE_(Seconds)), 0);
+			obs_property_list_add_int(p, TRANSLATE(G_KEYFRAMES_INTERVALTYPE_(Frames)), 1);
+		}
+		{
+			auto p =
+			    obs_properties_add_float(grp, G_KEYFRAMES_INTERVAL_SECONDS, TRANSLATE(G_KEYFRAMES_INTERVAL),
+			                             0.00, std::numeric_limits<int16_t>::max(), 0.01);
+			obs_property_set_long_description(p, TRANSLATE(DESC(G_KEYFRAMES_INTERVAL)));
+			obs_property_float_set_suffix(p, " seconds");
+		}
+		{
+			auto p =
+			    obs_properties_add_int(grp, G_KEYFRAMES_INTERVAL_FRAMES, TRANSLATE(G_KEYFRAMES_INTERVAL), 0,
+			                           std::numeric_limits<int32_t>::max(), 1);
+			obs_property_set_long_description(p, TRANSLATE(DESC(G_KEYFRAMES_INTERVAL)));
+			obs_property_int_set_suffix(p, " frames");
+		}
+	}
+
+	{
+		obs_properties_t* grp = props;
+		if (!obsffmpeg::are_property_groups_broken()) {
+			grp = obs_properties_create();
+			obs_properties_add_group(props, P_AQ, TRANSLATE(P_AQ), OBS_GROUP_NORMAL, grp);
+		}
+
+		{
+			auto p = obs_properties_add_bool(grp, P_AQ_SPATIAL, TRANSLATE(P_AQ_SPATIAL));
+			obs_property_set_long_description(p, TRANSLATE(DESC(P_AQ_SPATIAL)));
+			obs_property_set_modified_callback(p, modified_aq);
+		}
+		{
+			auto p = obs_properties_add_int_slider(grp, P_AQ_STRENGTH, TRANSLATE(P_AQ_STRENGTH), 1, 15, 1);
+			obs_property_set_long_description(p, TRANSLATE(DESC(P_AQ_STRENGTH)));
+		}
+		{
+			auto p = obs_properties_add_bool(grp, P_AQ_TEMPORAL, TRANSLATE(P_AQ_TEMPORAL));
+			obs_property_set_long_description(p, TRANSLATE(DESC(P_AQ_TEMPORAL)));
+		}
+	}
+
+	{
+		obs_properties_t* grp = props;
+		if (!obsffmpeg::are_property_groups_broken()) {
+			grp = obs_properties_create();
+			obs_properties_add_group(props, P_OTHER, TRANSLATE(P_OTHER), OBS_GROUP_NORMAL, grp);
+		}
+
+		{
+			auto p =
+			    obs_properties_add_int_slider(grp, P_OTHER_BFRAMES, TRANSLATE(P_OTHER_BFRAMES), 0, 4, 1);
+			obs_property_set_long_description(p, TRANSLATE(DESC(P_OTHER_BFRAMES)));
+			obs_property_int_set_suffix(p, " frames");
+		}
+
+		{
+			auto p = obs_properties_add_list(grp, P_OTHER_BFRAME_REFERENCEMODE,
+			                                 TRANSLATE(P_OTHER_BFRAME_REFERENCEMODE), OBS_COMBO_TYPE_LIST,
+			                                 OBS_COMBO_FORMAT_INT);
+			obs_property_set_long_description(p, TRANSLATE(DESC(P_OTHER_BFRAME_REFERENCEMODE)));
+			for (auto kv : b_ref_modes) {
+				obs_property_list_add_int(p, TRANSLATE(kv.second.c_str()),
+				                          static_cast<int64_t>(kv.first));
+			}
+		}
+
+		{
+			auto p = obs_properties_add_bool(grp, P_OTHER_ZEROLATENCY, TRANSLATE(P_OTHER_ZEROLATENCY));
+			obs_property_set_long_description(p, TRANSLATE(DESC(P_OTHER_ZEROLATENCY)));
+		}
+
+		{
+			auto p = obs_properties_add_bool(grp, P_OTHER_WEIGHTED_PREDICTION,
+			                                 TRANSLATE(P_OTHER_WEIGHTED_PREDICTION));
+			obs_property_set_long_description(p, TRANSLATE(DESC(P_OTHER_WEIGHTED_PREDICTION)));
+		}
+
+		{
+			auto p = obs_properties_add_bool(grp, P_OTHER_NONREFERENCE_PFRAMES,
+			                                 TRANSLATE(P_OTHER_NONREFERENCE_PFRAMES));
+			obs_property_set_long_description(p, TRANSLATE(DESC(P_OTHER_NONREFERENCE_PFRAMES)));
+		}
+	}
+}
+
+void obsffmpeg::nvenc::get_runtime_properties(obs_properties_t* props, AVCodec*, AVCodecContext*)
+{
+	obs_property_set_enabled(obs_properties_get(props, P_PRESET), false);
+	obs_property_set_enabled(obs_properties_get(props, P_RATECONTROL), false);
+	obs_property_set_enabled(obs_properties_get(props, P_RATECONTROL_MODE), false);
+	obs_property_set_enabled(obs_properties_get(props, P_RATECONTROL_TWOPASS), false);
+	obs_property_set_enabled(obs_properties_get(props, P_RATECONTROL_LOOKAHEAD), false);
+	obs_property_set_enabled(obs_properties_get(props, P_RATECONTROL_ADAPTIVEI), false);
+	obs_property_set_enabled(obs_properties_get(props, P_RATECONTROL_ADAPTIVEB), false);
+	obs_property_set_enabled(obs_properties_get(props, P_RATECONTROL_BITRATE), true);
+	obs_property_set_enabled(obs_properties_get(props, P_RATECONTROL_BITRATE_TARGET), true);
+	obs_property_set_enabled(obs_properties_get(props, P_RATECONTROL_BITRATE_MAXIMUM), true);
+	obs_property_set_enabled(obs_properties_get(props, G_RATECONTROL_BUFFERSIZE), true);
+	obs_property_set_enabled(obs_properties_get(props, P_RATECONTROL_QUALITY), false);
+	obs_property_set_enabled(obs_properties_get(props, P_RATECONTROL_QUALITY_MINIMUM), false);
+	obs_property_set_enabled(obs_properties_get(props, P_RATECONTROL_QUALITY_MAXIMUM), false);
+	obs_property_set_enabled(obs_properties_get(props, G_KEYFRAMES), false);
+	obs_property_set_enabled(obs_properties_get(props, G_KEYFRAMES_INTERVALTYPE), false);
+	obs_property_set_enabled(obs_properties_get(props, G_KEYFRAMES_INTERVAL_SECONDS), false);
+	obs_property_set_enabled(obs_properties_get(props, G_KEYFRAMES_INTERVAL_FRAMES), false);
+	obs_property_set_enabled(obs_properties_get(props, P_AQ), false);
+	obs_property_set_enabled(obs_properties_get(props, P_AQ_SPATIAL), false);
+	obs_property_set_enabled(obs_properties_get(props, P_AQ_STRENGTH), false);
+	obs_property_set_enabled(obs_properties_get(props, P_AQ_TEMPORAL), false);
+	obs_property_set_enabled(obs_properties_get(props, P_OTHER), false);
+	obs_property_set_enabled(obs_properties_get(props, P_OTHER_BFRAMES), false);
+	obs_property_set_enabled(obs_properties_get(props, P_OTHER_BFRAME_REFERENCEMODE), false);
+	obs_property_set_enabled(obs_properties_get(props, P_OTHER_ZEROLATENCY), false);
+	obs_property_set_enabled(obs_properties_get(props, P_OTHER_WEIGHTED_PREDICTION), false);
+	obs_property_set_enabled(obs_properties_get(props, P_OTHER_NONREFERENCE_PFRAMES), false);
+}
+
+void obsffmpeg::nvenc::update(obs_data_t* settings, AVCodec* codec, AVCodecContext* context)
+{
+	{
+		preset c_preset = static_cast<preset>(obs_data_get_int(settings, P_PRESET));
+		auto   found    = preset_to_opt.find(c_preset);
+		if (found != preset_to_opt.end()) {
+			av_opt_set(context->priv_data, "preset", found->second.c_str(), 0);
+		} else {
+			av_opt_set(context->priv_data, "preset", nullptr, 0);
+		}
+	}
+
+	{ // Rate Control
+		bool have_bitrate     = false;
+		bool have_bitrate_max = false;
+		bool have_quality_min = false;
+		bool have_quality_max = false;
+		bool have_qp          = false;
+		bool have_qp_init     = false;
+
+		ratecontrolmode rc    = static_cast<ratecontrolmode>(obs_data_get_int(settings, P_RATECONTROL_MODE));
+		auto            rcopt = nvenc::ratecontrolmode_to_opt.find(rc);
+		if (rcopt != nvenc::ratecontrolmode_to_opt.end()) {
+			av_opt_set(context->priv_data, "rc", rcopt->second.c_str(), 0);
+		}
+
+		switch (rc) {
+		case ratecontrolmode::CQP:
+			have_qp = true;
+			break;
+		case ratecontrolmode::CBR:
+		case ratecontrolmode::CBR_HQ:
+		case ratecontrolmode::CBR_LD_HQ:
+			have_bitrate = true;
+			av_opt_set_int(context->priv_data, "cbr", 1, 0);
+			break;
+		case ratecontrolmode::VBR:
+		case ratecontrolmode::VBR_HQ:
+			have_bitrate_max = true;
+			have_bitrate     = true;
+			have_quality_min = true;
+			have_quality_max = true;
+			have_qp_init     = true;
+			break;
+		}
+
+		int tp = static_cast<int>(obs_data_get_int(settings, P_RATECONTROL_TWOPASS));
+		if (tp >= 0) {
+			av_opt_set_int(context->priv_data, "2pass", tp ? 1 : 0, 0);
+		}
+
+		int la = static_cast<int>(obs_data_get_int(settings, P_RATECONTROL_LOOKAHEAD));
+		av_opt_set_int(context->priv_data, "lookahead", la, 0);
+		if (la > 0) {
+			bool adapt_i = obs_data_get_bool(settings, P_RATECONTROL_ADAPTIVEI);
+			av_opt_set_int(context->priv_data, "no-scenecut", !adapt_i ? 1 : 0, 0);
+
+			if (strcmp(codec->name, "h264_nvenc")) {
+				bool adapt_b = obs_data_get_bool(settings, P_RATECONTROL_ADAPTIVEB);
+				av_opt_set_int(context->priv_data, "b_adapt", adapt_b ? 1 : 0, 0);
+			}
+		}
+
+		if (have_bitrate)
+			context->bit_rate =
+			    static_cast<int>(obs_data_get_int(settings, P_RATECONTROL_BITRATE_TARGET) * 1000);
+		if (have_bitrate_max)
+			context->rc_max_rate =
+			    static_cast<int>(obs_data_get_int(settings, P_RATECONTROL_BITRATE_MAXIMUM) * 1000);
+		if (have_bitrate || have_bitrate_max)
+			context->rc_buffer_size =
+			    static_cast<int>(obs_data_get_int(settings, G_RATECONTROL_BUFFERSIZE) * 1000);
+
+		if (have_quality_min && obs_data_get_bool(settings, P_RATECONTROL_QUALITY)) {
+			int qmin      = static_cast<int>(obs_data_get_int(settings, P_RATECONTROL_QUALITY_MINIMUM));
+			context->qmin = qmin;
+			if ((qmin >= 0) && (have_quality_max)) {
+				context->qmax =
+				    static_cast<int>(obs_data_get_int(settings, P_RATECONTROL_QUALITY_MAXIMUM));
+			}
+		}
+
+		if (have_qp) {
+			av_opt_set_int(context->priv_data, "init_qpI",
+			               static_cast<int>(obs_data_get_int(settings, G_RATECONTROL_QP_I)), 0);
+			av_opt_set_int(context->priv_data, "init_qpP",
+			               static_cast<int>(obs_data_get_int(settings, G_RATECONTROL_QP_P)), 0);
+			av_opt_set_int(context->priv_data, "init_qpB",
+			               static_cast<int>(obs_data_get_int(settings, G_RATECONTROL_QP_B)), 0);
+		}
+		if (have_qp_init) {
+			av_opt_set_int(context->priv_data, "init_qpI",
+			               obs_data_get_int(settings, G_RATECONTROL_QP_I_INITIAL), 0);
+			av_opt_set_int(context->priv_data, "init_qpP",
+			               obs_data_get_int(settings, G_RATECONTROL_QP_P_INITIAL), 0);
+			av_opt_set_int(context->priv_data, "init_qpB",
+			               obs_data_get_int(settings, G_RATECONTROL_QP_B_INITIAL), 0);
+		}
+	}
+
+	{ // Key Frames
+		obs_video_info ovi;
+		if (!obs_get_video_info(&ovi)) {
+			throw std::runtime_error("no video info");
+		}
+
+		int64_t kf_type    = obs_data_get_int(settings, G_KEYFRAMES_INTERVALTYPE);
+		bool    is_seconds = (kf_type == 0);
+
+		if (is_seconds) {
+			context->gop_size = static_cast<int>(obs_data_get_double(settings, G_KEYFRAMES_INTERVAL_SECONDS)
+			                                     * (ovi.fps_num / ovi.fps_den));
+		} else {
+			context->gop_size = static_cast<int>(obs_data_get_int(settings, G_KEYFRAMES_INTERVAL_FRAMES));
+		}
+		context->keyint_min = context->gop_size;
+	}
+
+	{ // AQ
+		bool saq  = obs_data_get_bool(settings, P_AQ_SPATIAL);
+		int  saqs = static_cast<int>(obs_data_get_int(settings, P_AQ_STRENGTH));
+		bool taq  = obs_data_get_bool(settings, P_AQ_TEMPORAL);
+
+		if (strcmp(codec->name, "h264_nvenc")) {
+			av_opt_set_int(context->priv_data, "spatial-aq", saq ? 1 : 0, 0);
+			av_opt_set_int(context->priv_data, "temporal-aq", taq ? 1 : 0, 0);
+		} else {
+			av_opt_set_int(context->priv_data, "spatial_aq", saq ? 1 : 0, 0);
+			av_opt_set_int(context->priv_data, "temporal_aq", taq ? 1 : 0, 0);
+		}
+		av_opt_set_int(context->priv_data, "aq-strength", saqs, 0);
+	}
+
+	{ // Other
+		bool zl  = obs_data_get_bool(settings, P_OTHER_ZEROLATENCY);
+		bool wp  = obs_data_get_bool(settings, P_OTHER_WEIGHTED_PREDICTION);
+		bool nrp = obs_data_get_bool(settings, P_OTHER_NONREFERENCE_PFRAMES);
+
+		context->max_b_frames = static_cast<int>(obs_data_get_int(settings, P_OTHER_BFRAMES));
+
+		av_opt_set_int(context->priv_data, "zerolatency", zl ? 1 : 0, 0);
+		av_opt_set_int(context->priv_data, "nonref_p", nrp ? 1 : 0, 0);
+
+		if ((context->max_b_frames != 0) && wp) {
+			PLOG_WARNING(
+			    "Automatically disabled weighted prediction due to being incompatible with B-Frames.");
+		} else {
+			av_opt_set_int(context->priv_data, "weighted_pred", wp ? 1 : 0, 0);
+		}
+
+		{
+			auto found = b_ref_mode_to_opt.find(
+			    static_cast<b_ref_mode>(obs_data_get_int(settings, P_OTHER_BFRAME_REFERENCEMODE)));
+			if (found != b_ref_mode_to_opt.end()) {
+				av_opt_set(context->priv_data, "b_ref_mode", found->second.c_str(), 0);
+			}
+		}
+	}
+}

source/ui/nvenc_shared.hpp

@@ -0,0 +1,84 @@
+// FFMPEG Video Encoder Integration for OBS Studio
+// Copyright (C) 2018 - 2019 Michael Fabian Dirks
+//
+// This program is free software; you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation; either version 2 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program; if not, write to the Free Software
+// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+
+#pragma once
+#include <map>
+#include "utility.hpp"
+
+extern "C" {
+#include <obs-properties.h>
+#pragma warning(push)
+#pragma warning(disable : 4244)
+#include <libavcodec/avcodec.h>
+#pragma warning(pop)
+}
+
+namespace obsffmpeg {
+	namespace nvenc {
+		enum class preset : int64_t {
+			DEFAULT,
+			SLOW,
+			MEDIUM,
+			FAST,
+			HIGH_PERFORMANCE,
+			HIGH_QUALITY,
+			BLURAYDISC,
+			LOW_LATENCY,
+			LOW_LATENCY_HIGH_PERFORMANCE,
+			LOW_LATENCY_HIGH_QUALITY,
+			LOSSLESS,
+			LOSSLESS_HIGH_PERFORMANCE,
+		};
+
+		enum class ratecontrolmode : int64_t {
+			CQP,
+			VBR,
+			VBR_HQ,
+			CBR,
+			CBR_HQ,
+			CBR_LD_HQ,
+		};
+
+		enum class b_ref_mode : int64_t {
+			DISABLED,
+			EACH,
+			MIDDLE,
+		};
+
+		extern std::map<preset, std::string> presets;
+
+		extern std::map<preset, std::string> preset_to_opt;
+
+		extern std::map<ratecontrolmode, std::string> ratecontrolmodes;
+
+		extern std::map<ratecontrolmode, std::string> ratecontrolmode_to_opt;
+
+		extern std::map<b_ref_mode, std::string> b_ref_modes;
+
+		extern std::map<b_ref_mode, std::string> b_ref_mode_to_opt;
+
+		void get_defaults(obs_data_t* settings, AVCodec* codec, AVCodecContext* context);
+
+		void get_properties_pre(obs_properties_t* props, AVCodec* codec);
+
+		void get_properties_post(obs_properties_t* props, AVCodec* codec);
+
+		void get_runtime_properties(obs_properties_t* props, AVCodec* codec, AVCodecContext* context);
+
+		void update(obs_data_t* settings, AVCodec* codec, AVCodecContext* context);
+	} // namespace nvenc
+} // namespace obsffmpeg

source/ui/prores_aw_handler.cpp

@@ -0,0 +1,79 @@
+// FFMPEG Video Encoder Integration for OBS Studio
+// Copyright (C) 2018 - 2019 Michael Fabian Dirks
+//
+// This program is free software; you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation; either version 2 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program; if not, write to the Free Software
+// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+
+#include "prores_aw_handler.hpp"
+#include "plugin.hpp"
+#include "utility.hpp"
+
+extern "C" {
+#include <obs-module.h>
+}
+
+#define P_PROFILE "AppleProRes.Profile"
+#define P_PROFILE_APCO "AppleProRes.Profile.APCO"
+#define P_PROFILE_APCS "AppleProRes.Profile.APCS"
+#define P_PROFILE_APCN "AppleProRes.Profile.APCN"
+#define P_PROFILE_APCH "AppleProRes.Profile.APCH"
+#define P_PROFILE_AP4H "AppleProRes.Profile.AP4H"
+
+INITIALIZER(prores_aw_handler_init)
+{
+	obsffmpeg::initializers.push_back([]() {
+		obsffmpeg::register_codec_handler("prores_aw", std::make_shared<obsffmpeg::ui::prores_aw_handler>());
+	});
+};
+
+void obsffmpeg::ui::prores_aw_handler::get_defaults(obs_data_t* settings, AVCodec*, AVCodecContext*)
+{
+	obs_data_set_default_int(settings, P_PROFILE, 0);
+}
+
+void obsffmpeg::ui::prores_aw_handler::get_properties(obs_properties_t* props, AVCodec* codec, AVCodecContext* context)
+{
+	if (!context) {
+		auto p = obs_properties_add_list(props, P_PROFILE, TRANSLATE(P_PROFILE), OBS_COMBO_TYPE_LIST,
+		                                 OBS_COMBO_FORMAT_INT);
+		obs_property_set_long_description(p, TRANSLATE(DESC(P_PROFILE)));
+		for (auto ptr = codec->profiles; ptr->profile != FF_PROFILE_UNKNOWN; ptr++) {
+			if (strcmp("apco", ptr->name) == 0) {
+				obs_property_list_add_int(p, TRANSLATE(P_PROFILE_APCO),
+				                          static_cast<int64_t>(ptr->profile));
+			} else if (strcmp("apcs", ptr->name) == 0) {
+				obs_property_list_add_int(p, TRANSLATE(P_PROFILE_APCS),
+				                          static_cast<int64_t>(ptr->profile));
+			} else if (strcmp("apcn", ptr->name) == 0) {
+				obs_property_list_add_int(p, TRANSLATE(P_PROFILE_APCN),
+				                          static_cast<int64_t>(ptr->profile));
+			} else if (strcmp("apch", ptr->name) == 0) {
+				obs_property_list_add_int(p, TRANSLATE(P_PROFILE_APCH),
+				                          static_cast<int64_t>(ptr->profile));
+			} else if (strcmp("ap4h", ptr->name) == 0) {
+				obs_property_list_add_int(p, TRANSLATE(P_PROFILE_AP4H),
+				                          static_cast<int64_t>(ptr->profile));
+			} else {
+				obs_property_list_add_int(p, ptr->name, ptr->profile);
+			}
+		}
+	} else {
+		obs_property_set_enabled(obs_properties_get(props, P_PROFILE), false);
+	}
+}
+
+void obsffmpeg::ui::prores_aw_handler::update(obs_data_t* settings, AVCodec*, AVCodecContext* context)
+{
+	context->profile = static_cast<int>(obs_data_get_int(settings, P_PROFILE));
+}

source/ui/prores_aw_handler.hpp

@@ -0,0 +1,42 @@
+// FFMPEG Video Encoder Integration for OBS Studio
+// Copyright (C) 2018 - 2019 Michael Fabian Dirks
+//
+// This program is free software; you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation; either version 2 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program; if not, write to the Free Software
+// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+
+#pragma once
+#include "handler.hpp"
+
+extern "C" {
+#include <obs-properties.h>
+#pragma warning(push)
+#pragma warning(disable : 4244)
+#include <libavcodec/avcodec.h>
+#pragma warning(pop)
+}
+
+namespace obsffmpeg {
+	namespace ui {
+		class prores_aw_handler : public handler {
+			public:
+			virtual void get_defaults(obs_data_t* settings, AVCodec* codec,
+			                          AVCodecContext* context) override;
+
+			virtual void get_properties(obs_properties_t* props, AVCodec* codec,
+			                            AVCodecContext* context) override;
+
+			virtual void update(obs_data_t* settings, AVCodec* codec, AVCodecContext* context) override;
+		};
+	} // namespace ui
+} // namespace obsffmpeg

source/utility.hpp

@@ -15,14 +15,17 @@
 // along with this program; if not, write to the Free Software
 // Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
 
-#ifndef OBS_FFMPEG_UTILITY_HPP
-#define OBS_FFMPEG_UTILITY_HPP
 #pragma once
 
 #include "version.hpp"
 
+extern "C" {
+#include <obs-config.h>
+#include <obs.h>
+}
+
 // Logging
-#define PLOG(level, ...) blog(level, "["##PROJECT_NAME##"] " __VA_ARGS__);
+#define PLOG(level, ...) blog(level, "[obs-ffmpeg-encoder] " __VA_ARGS__);
 #define PLOG_ERROR(...) PLOG(LOG_ERROR, __VA_ARGS__)
 #define PLOG_WARNING(...) PLOG(LOG_WARNING, __VA_ARGS__)
 #define PLOG_INFO(...) PLOG(LOG_INFO, __VA_ARGS__)
@@ -42,7 +45,42 @@
 #define DESC(x) x ".Description"
 
 // Other
-#define vstr(s) dstr(s)
-#define dstr(s) #s
+#define D_STR(s) #s
+#define D_VSTR(s) D_STR(s)
 
-#endif OBS_FFMPEG_UTILITY_HPP
+// Initializer
+#ifdef __cplusplus
+#define INITIALIZER(f) \
+	static void f(void); \
+	struct f##_t_ { \
+		f##_t_(void) \
+		{ \
+			f(); \
+		} \
+	}; \
+	static f##_t_ f##_; \
+	static void   f(void)
+#elif defined(_MSC_VER)
+#pragma section(".CRT$XCU", read)
+#define INITIALIZER2_(f, p) \
+	static void f(void); \
+	__declspec(allocate(".CRT$XCU")) void (*f##_)(void) = f; \
+	__pragma(comment(linker, "/include:" p #f "_")) static void f(void)
+#ifdef _WIN64
+#define INITIALIZER(f) INITIALIZER2_(f, "")
+#else
+#define INITIALIZER(f) INITIALIZER2_(f, "_")
+#endif
+#else
+#define INITIALIZER(f) \
+	static void f(void) __attribute__((constructor)); \
+	static void f(void)
+#endif
+
+// Helpers
+namespace obsffmpeg {
+	bool inline are_property_groups_broken()
+	{
+		return obs_get_version() < MAKE_SEMANTIC_VERSION(24, 0, 0);
+	}
+} // namespace obsffmpeg